pkg/analysis_server/test/services/completion/completion_test_util.dart - Issue 1525753003: extract LocalLibraryContributor from imported reference contributor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/completion/completion_test_util.dart

Issue 1525753003: extract LocalLibraryContributor from imported reference contributor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: merge Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart ('k') | pkg/analysis_server/test/services/completion/dart/local_library_contributor_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/completion/completion_test_util.dart

diff --git a/pkg/analysis_server/test/services/completion/completion_test_util.dart b/pkg/analysis_server/test/services/completion/completion_test_util.dart

index 3fd76871df1d537f048a1bbf65b5f5692082c846..68d8d355eb120d0aa5db30b8015b7ea205f301c9 100644

--- a/pkg/analysis_server/test/services/completion/completion_test_util.dart

+++ b/pkg/analysis_server/test/services/completion/completion_test_util.dart

@@ -3753,7 +3753,8 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {

assertSuggestImportedConstructor('Object');

assertSuggestImportedConstructor('X.c');

assertNotSuggested('X._d');

- assertSuggestImportedConstructor('A');

+ // Suggested by LocalLibraryContributor

+ assertNotSuggested('A');

assertNotSuggested('F1');

assertNotSuggested('T1');

assertNotSuggested('_d');

@@ -3792,7 +3793,8 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {