tools/metrics/histograms/histograms.xml - Issue 1525743002: Allow ServiceWorker events to have custom durations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1525743002: Allow ServiceWorker events to have custom durations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments from PS8 Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« content/browser/service_worker/service_worker_version_unittest.cc ('K') | « content/browser/service_worker/service_worker_version_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 3c55c73687a15ee1f99a360771b3495ba3604a62..2acc8ae08769bfaf08950057866d0d55a8fb76e8 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -43041,6 +43041,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<summary>The result of dispatching the activate event to the worker.</summary>

</histogram>

+<histogram name="ServiceWorker.BackgroundSyncEvent.Time" units="milliseconds">

Ilya Sherman 2015/12/17 21:41:37 nit: Perhaps "Duration" rather than "Time"?

falken 2015/12/18 01:28:48 That's probably better, but the other SW UMAs use

jkarlin 2015/12/18 12:28:30 Agree with both. Keeping with "Time" for consisten

+ <owner>jkarlin@chromium.org</owner>

+ <summary>

+ The time taken between dispatching a SyncEvent to a Service Worker and

+ receiving a message that it finished handling the event. Includes the time

+ for the waitUntil() promise to settle.

+ </summary>

+</histogram>

<histogram name="ServiceWorker.Database.DestroyDatabaseResult"

enum="ServiceWorkerDatabaseStatus">

<owner>nhiroki@chromium.org</owner>