Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1525733002: Revert of Only set -rpath=$ORIGIN in component builds by default. (Closed)

Created:
5 years ago by dcheng
Modified:
5 years ago
CC:
cc-bugs_chromium.org, chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Only set -rpath=$ORIGIN in component builds by default. (patchset #3 id:40001 of https://codereview.chromium.org/1514203002/ ) Reason for revert: Breaks Linux GN components_browsertests: components_browsertests: error while loading shared libraries: libblink_test_plugin.so: cannot open shared object file: No such file or directory Original issue's description: > Only set -rpath=$ORIGIN in component builds by default. > > Statically-linked binaries do not need -rpath=$ORIGIN > set, and setting it can be a source of strange security > issues (see bug for more details). > > Manually add this to some test binaries that require shared libraries to be loaded from the build directory. > > R=phajdan.jr@chromium.org, thestig@chromium.org > BUG=556843 > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_ng > > Forked from http://crrev.com/1448213002 > > Committed: https://crrev.com/3de132ceb95eb0d1fd40b611374d6868c717d2b4 > Cr-Commit-Position: refs/heads/master@{#364877} TBR=phajdan.jr@chromium.org,dpranke@chromium.org,thestig@chromium.org,jam@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=556843 Committed: https://crrev.com/3777a456451ab42f94e1dc29c9f52a03c7a312fe Cr-Commit-Position: refs/heads/master@{#365068}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -98 lines) Patch
M base/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M build/config/gcc/BUILD.gn View 2 chunks +8 lines, -44 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M mojo/common/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/edk/test/BUILD.gn View 6 chunks +0 lines, -36 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dcheng
Created Revert of Only set -rpath=$ORIGIN in component builds by default.
5 years ago (2015-12-14 19:20:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525733002/1
5 years ago (2015-12-14 19:23:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-14 19:24:51 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3777a456451ab42f94e1dc29c9f52a03c7a312fe Cr-Commit-Position: refs/heads/master@{#365068}
5 years ago (2015-12-14 19:25:47 UTC) #5
brettw
5 years ago (2015-12-14 20:38:55 UTC) #6
Message was sent while issue was closed.
If this didn't break any bots, I would have appreciated a ping before you
reverted this. The fix is one line, and this is a security issue I need to land
on the branch.

Powered by Google App Engine
This is Rietveld 408576698