DescriptionRevert of Only set -rpath=$ORIGIN in component builds by default. (patchset #3 id:40001 of https://codereview.chromium.org/1514203002/ )
Reason for revert:
Breaks Linux GN components_browsertests:
components_browsertests: error while loading shared libraries: libblink_test_plugin.so: cannot open shared object file: No such file or directory
Original issue's description:
> Only set -rpath=$ORIGIN in component builds by default.
>
> Statically-linked binaries do not need -rpath=$ORIGIN
> set, and setting it can be a source of strange security
> issues (see bug for more details).
>
> Manually add this to some test binaries that require shared libraries to be loaded from the build directory.
>
> R=phajdan.jr@chromium.org, thestig@chromium.org
> BUG=556843
> CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_ng
>
> Forked from http://crrev.com/1448213002
>
> Committed: https://crrev.com/3de132ceb95eb0d1fd40b611374d6868c717d2b4
> Cr-Commit-Position: refs/heads/master@{#364877}
TBR=phajdan.jr@chromium.org,dpranke@chromium.org,thestig@chromium.org,jam@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=556843
Committed: https://crrev.com/3777a456451ab42f94e1dc29c9f52a03c7a312fe
Cr-Commit-Position: refs/heads/master@{#365068}
Patch Set 1 #
Messages
Total messages: 6 (1 generated)
|