Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 1525703003: Revert of [stubs] Fix TypeOfStub to properly return "undefined" for undetectable. (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [stubs] Fix TypeOfStub to properly return "undefined" for undetectable. (patchset #1 id:1 of https://codereview.chromium.org/1527863003/ ) Reason for revert: [Sheriff] Changes layout tests. Please fix upstream first: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3491 Original issue's description: > [stubs] Fix TypeOfStub to properly return "undefined" for undetectable. > > The TypeOfStub didn't test the undetectable bit properly if the instance > was also callable, and therefore returned "object" for document.all > (which is both undetectable and callable). > > R=yangguo@chromium.org > BUG=chromium:567998 > LOG=n > > Committed: https://crrev.com/02cc310370df7e51ac4f705038820066fdfd0cdc > Cr-Commit-Position: refs/heads/master@{#32852} TBR=yangguo@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:567998 Committed: https://crrev.com/88e11c80ad99741c9ac852183f1e3b50370a287c Cr-Commit-Position: refs/heads/master@{#32855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -49 lines) Patch
M src/code-stubs-hydrogen.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -48 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [stubs] Fix TypeOfStub to properly return "undefined" for undetectable.
5 years ago (2015-12-15 09:31:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525703003/1
5 years ago (2015-12-15 09:31:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 09:31:47 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-15 09:32:08 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88e11c80ad99741c9ac852183f1e3b50370a287c
Cr-Commit-Position: refs/heads/master@{#32855}

Powered by Google App Engine
This is Rietveld 408576698