Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1525663003: Move the remainder of generated/element.dart into better locations (Closed)

Created:
5 years ago by Brian Wilkerson
Modified:
5 years ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move the remainder of generated/element.dart into better locations. There are no other changes to the code. Clean-up of imports and moving of related tests will follow. R=paulberry@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/e057af83d82900735a816f3c224fc3db97509e05

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3519 lines, -11350 lines) Patch
M pkg/analyzer/CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
A + pkg/analyzer/lib/src/dart/element/element.dart View 17 chunks +143 lines, -3469 lines 0 comments Download
A pkg/analyzer/lib/src/dart/element/member.dart View 1 chunk +965 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/dart/element/type.dart View 1 chunk +2394 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 1 chunk +14 lines, -7881 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Brian Wilkerson
5 years ago (2015-12-14 17:46:50 UTC) #3
scheglov
LGTM
5 years ago (2015-12-14 17:49:33 UTC) #4
Paul Berry
lgtm. I like your strategy of moving the declarations into reasonable places and adding export ...
5 years ago (2015-12-14 17:52:01 UTC) #5
Brian Wilkerson
5 years ago (2015-12-14 17:54:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e057af83d82900735a816f3c224fc3db97509e05 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698