[interpreter] Unify decision how to compile baseline code.

[interpreter] Unify decision how to compile baseline code.

This unifies the decision whether to use Ignition or FullCodeGenerator
to generate baseline code into a single place. This allows for small
function literals that are compiled eagerly to go through Ignition.

R=rmcilroy@chromium.org

Committed: https://crrev.com/3b52a537736d0a94237b2022861bbf5180239a5c
Cr-Commit-Position: refs/heads/master@{#32848}

[Michael Starzinger, 2015-12-14 17:30:15]

Description was changed from

==========
[interpreter] Unify decision how to compile baseline code.

This unifies the decision whether to use Ignition or FullCodeGenerator
to generate baseline code into a single place. This also makes small
function literals that are compiled eagerly go through Ignition.

BUG=
==========

to

==========
[interpreter] Unify decision how to compile baseline code.

This unifies the decision whether to use Ignition or FullCodeGenerator
to generate baseline code into a single place. This also makes small
function literals that are compiled eagerly go through Ignition.

R=rmcilroy@chromium.org
==========

[Michael Starzinger, 2015-12-14 17:30:15]

mstarzinger@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[rmcilroy, 2015-12-14 18:09:36]

https://codereview.chromium.org/1525663002/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1525663002/diff/1/src/compiler.cc#newcode728
src/compiler.cc:728: !IgnitionShouldFallbackToFullCodeGen(info->scope())) {
I think this should not have the "!"

https://codereview.chromium.org/1525663002/diff/1/src/compiler.cc#newcode743
src/compiler.cc:743: static bool GenerateFullCodeOrBytecode(CompilationInfo*
info) {
Nit - GenerateBaselineCode(..) ? The current name makes me think this returns
true for fullcodegen / false for Ignition.

[Michael Starzinger, 2015-12-14 18:21:24]

https://codereview.chromium.org/1525663002/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1525663002/diff/1/src/compiler.cc#newcode728
src/compiler.cc:728: !IgnitionShouldFallbackToFullCodeGen(info->scope())) {
On 2015/12/14 18:09:35, rmcilroy wrote:
> I think this should not have the "!"

Done.

https://codereview.chromium.org/1525663002/diff/1/src/compiler.cc#newcode743
src/compiler.cc:743: static bool GenerateFullCodeOrBytecode(CompilationInfo*
info) {
On 2015/12/14 18:09:35, rmcilroy wrote:
> Nit - GenerateBaselineCode(..) ? The current name makes me think this returns
> true for fullcodegen / false for Ignition.

Done.

[Michael Starzinger, 2015-12-14 18:45:18]

Description was changed from

==========
[interpreter] Unify decision how to compile baseline code.

This unifies the decision whether to use Ignition or FullCodeGenerator
to generate baseline code into a single place. This also makes small
function literals that are compiled eagerly go through Ignition.

R=rmcilroy@chromium.org
==========

to

==========
[interpreter] Unify decision how to compile baseline code.

This unifies the decision whether to use Ignition or FullCodeGenerator
to generate baseline code into a single place. This allows for small
function literals that are compiled eagerly to go through Ignition.

R=rmcilroy@chromium.org
==========

[rmcilroy, 2015-12-14 20:52:38]

lgtm, thanks!

[Michael Starzinger, 2015-12-14 20:56:27]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2015-12-14 20:56:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1525663002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1525663002/40001

[Michael Starzinger, 2015-12-14 20:56:30]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2015-12-14 20:57:44]

Description was changed from

==========
[interpreter] Unify decision how to compile baseline code.

This unifies the decision whether to use Ignition or FullCodeGenerator
to generate baseline code into a single place. This allows for small
function literals that are compiled eagerly to go through Ignition.

R=rmcilroy@chromium.org
==========

to

==========
[interpreter] Unify decision how to compile baseline code.

This unifies the decision whether to use Ignition or FullCodeGenerator
to generate baseline code into a single place. This allows for small
function literals that are compiled eagerly to go through Ignition.

R=rmcilroy@chromium.org
==========

[commit-bot: I haz the power, 2015-12-14 20:57:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-14 20:58:41]

Description was changed from

==========
[interpreter] Unify decision how to compile baseline code.

This unifies the decision whether to use Ignition or FullCodeGenerator
to generate baseline code into a single place. This allows for small
function literals that are compiled eagerly to go through Ignition.

R=rmcilroy@chromium.org
==========

to

==========
[interpreter] Unify decision how to compile baseline code.

This unifies the decision whether to use Ignition or FullCodeGenerator
to generate baseline code into a single place. This allows for small
function literals that are compiled eagerly to go through Ignition.

R=rmcilroy@chromium.org

Committed: https://crrev.com/3b52a537736d0a94237b2022861bbf5180239a5c
Cr-Commit-Position: refs/heads/master@{#32848}
==========

[commit-bot: I haz the power, 2015-12-14 20:58:42]

Patchset 3 (id:??) landed as
https://crrev.com/3b52a537736d0a94237b2022861bbf5180239a5c
Cr-Commit-Position: refs/heads/master@{#32848}