third_party/WebKit/LayoutTests/fast/text/tifinagh.html - Issue 1525653002: Use Ebrima as fallback font for Tifinagh in Windows.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/text/tifinagh.html

Issue 1525653002: Use Ebrima as fallback font for Tifinagh in Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Now with tests. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>(Neo-)Tifinagh glyphs</title>

	5 </head>

	6 <body>

	7 <h1>(Neo-)Tifinagh glyphs</h1>

	8 <script>

	9 function emitChar(charCode) {

	10 document.write("&#x" + charCode.toString(16) + "; (U+" +
	drott 2015/12/16 08:52:06 Thanks for adding a test, unless there is a specif Thanks for adding a test, unless there is a specific reason to use document.write here, I would suggest to use static HTML entities such as &x2d30; or placing the Tifinagh text directly and adding a <meta charset="utf-8"> in the header instead of document.write. Daniel Bratell 2015/12/16 09:17:24 This is way easier to work with. We can easily che Show quoted text On 2015/12/16 08:52:06, drott wrote: > Thanks for adding a test, unless there is a specific reason to use > document.write here, I would suggest to use static HTML entities such as &x2d30; > or placing the Tifinagh text directly and adding a <meta charset="utf-8"> in the > header instead of document.write. This is way easier to work with. We can easily check that we have not forgotten any glyphs, that the two blocks (monospace and default font) contain the same glyphs. That the labels and the glyphs are referencing the same codepoint. Since it's pure ASCII it will also not be vulnerable to misunderstandings by editors or other tools which is particularly important when working with glyphs that not every tool/environment can render. It's also possible to quickly reuse this test for other scripts. For instance https://codereview.chromium.org/1521993008/patch/1/10002 is the same with just 2-3 lines changed. Doing the same thing manually would be much more error prone. I was going to say that it loses a bit in reviewability, but then I reconsidered. Reviewing a list of a hundred glyphs, checking that they are all there, that they use the right code point, the right label, that would be much harder than reading this script and seeing the start and end of the loop. (I actually started by modifying an existing testcase that wrote the characters literally but it was not at all easy and quite timeconsuming so I switched to a scripted loop instead).
	11 charCode.toString(16).toUpperCase() +

	12 ")     ");

	13 }

	14 function emitCharSequence(first, last) {

	15 for (var i = first; i <= last; i++)

	16 emitChar(i);

	17 }

	18 document.write("<b>Mono space</b>");

	19 document.write("<pre style='white-space: pre-wrap'>");

	20 emitCharSequence(0x2D30, 0x2D67);

	21 emitCharSequence(0x2D6F, 0x2D6F);

	22 document.write("</pre>");

	23

	24 document.write("<b>Default font</b>");

	25 document.write("<p>")

	26 emitCharSequence(0x2D30, 0x2D67);

	27 emitCharSequence(0x2D6F, 0x2D6F);

	28 </script>

	29 <p>

	30 There should be many interesting glyphs above. See

	31 <a href="https://en.wikipedia.org/wiki/Tifinagh">

	32 https://en.wikipedia.org/wiki/Tifinagh</a> for more.

	33 </body>

	34 </html>

OLD	NEW