pkg/compiler/lib/src/ssa/optimize.dart - Issue 1525603002: Associate compile-time errors with elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/ssa/optimize.dart

Issue 1525603002: Associate compile-time errors with elements (Closed) Base URL: git@github.com:dart-lang/sdk.git@_temporary_fletch_patches

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/ssa/optimize.dart

diff --git a/pkg/compiler/lib/src/ssa/optimize.dart b/pkg/compiler/lib/src/ssa/optimize.dart

index c98ceb170055e5e02bf38e40aafe8b3e5479083f..b4f00e2d9edda349e22e5b95117f166668989651 100644

--- a/pkg/compiler/lib/src/ssa/optimize.dart

+++ b/pkg/compiler/lib/src/ssa/optimize.dart

@@ -2008,7 +2008,8 @@ class SsaLoadElimination extends HBaseVisitor implements OptimizationPhase {

if (shouldTrackInitialValues(instruction)) {

int argumentIndex = 0;

instruction.element.forEachInstanceField((_, Element member) {

- if (compiler.elementHasCompileTimeError(member)) return;

+ if (compiler.generateCodeWithCompileTimeErrors &&

+ compiler.elementHasCompileTimeError(member)) return;

memorySet.registerFieldValue(

member, instruction, instruction.inputs[argumentIndex++]);

}, includeSuperAndInjectedMembers: true);