Rewrite parts of http-parser, to better handle connection errors and pausing.

tests/standalone/io/http_parser_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import "package:expect/expect.dart";
 import 'dart:async';
 import 'dart:math';
 import 'dart:typed_data';
 import 'dart:isolate';
 import 'dart:uri';
@@ skipping 58 matching lines @@
               Expect.equals(value, headers[name][0]));
         }
         incoming.listen(
             (List<int> data) {
               Expect.isFalse(upgraded);
               bytesReceived += data.length;
             },
             onDone: () {
               Expect.isFalse(upgraded);
               port2.close();
+              Expect.equals(expectedMethod, method);
+              Expect.stringEquals(expectedUri, uri.toString());
+              Expect.equals(expectedVersion, headers.protocolVersion);
+              if (upgrade) {
+                Expect.equals(0, bytesReceived);
+                // port1 is closed by the listener on the detached data.
+              } else {
+                Expect.equals(expectedBytesReceived, bytesReceived);
+              }
             });
 
         if (upgraded) {
           port1.close();
           httpParser.detachIncoming().listen(
               (List<int> data) {
                 unparsedBytesReceived += data.length;
               },
               onDone: () {
                 Expect.equals(unparsedLength, unparsedBytesReceived);
                 port2.close();
               });
         }
 
         incoming.dataDone.then((_) {
           port1.close();
           Expect.isFalse(upgraded);
-          Expect.equals(expectedMethod, method);
-          Expect.stringEquals(expectedUri, uri.toString());
-          Expect.equals(expectedVersion, headers.protocolVersion);
-          if (upgrade) {
-            Expect.equals(0, bytesReceived);
-            // port1 is closed by the listener on the detached data.
-          } else {
-            Expect.equals(expectedBytesReceived, bytesReceived);
-          }
         });
       });
 
       method = null;
       uri = null;
       headers = null;
       bytesReceived = 0;
       unparsedBytesReceived = 0;
       upgraded = false;
     }
@@ skipping 65 matching lines @@
                                  {int expectedTransferLength: 0,
                                   int expectedBytesReceived: 0,
                                   Map expectedHeaders: null,
                                   bool chunked: false,
                                   bool close: false,
                                   String responseToMethod: null,
                                   bool connectionClose: false,
                                   bool upgrade: false,
                                   int unparsedLength: 0,
                                   String expectedVersion: "1.1"}) {
-    _HttpParser httpParser;
-    bool headersCompleteCalled;
-    bool dataEndCalled;
-    bool dataEndClose;
-    int statusCode;
-    String reasonPhrase;
-    HttpHeaders headers;
-    int contentLength;
-    int bytesReceived;
     StreamController controller;
     bool upgraded;
 
     void reset() {
+      _HttpParser httpParser;
+      bool headersCompleteCalled;
+      bool dataEndCalled;
+      bool dataEndClose;
+      int statusCode;
+      String reasonPhrase;
+      HttpHeaders headers;
+      int contentLength;
+      int bytesReceived;
       httpParser = new _HttpParser.responseParser();
       controller = new StreamController();
       var port = new ReceivePort();
       controller.stream.pipe(httpParser);
       var subscription = httpParser.listen((incoming) {
         port.close();
         statusCode = incoming.statusCode;
         reasonPhrase = incoming.reasonPhrase;
         headers = incoming.headers;
         Expect.isFalse(headersCompleteCalled);
@@ skipping 118 matching lines @@
         "SEARCH",
         // Methods with HTTP prefix.
         "H", "HT", "HTT", "HTTP", "HX", "HTX", "HTTX", "HTTPX"];
     methods.forEach((method) {
        request = "$method / HTTP/1.1\r\n\r\n";
       _testParseRequest(request, method, "/");
        request = "$method /index.html HTTP/1.1\r\n\r\n";
       _testParseRequest(request, method, "/index.html");
     });
 
-
     request = "GET / HTTP/1.0\r\n\r\n";
     _testParseRequest(request, "GET", "/",
                       expectedVersion: "1.0",
                       connectionClose: true);
 
     request = "GET / HTTP/1.0\r\nConnection: keep-alive\r\n\r\n";
     _testParseRequest(request, "GET", "/", expectedVersion: "1.0");
 
     request = """
 POST /test HTTP/1.1\r
@@ skipping 44 matching lines @@
 
     request = """
 POST /test HTTP/1.1\r
 Header-A:   AA\r
  A\r
 X-Header-B:           b\r
   b\r
 \t    b\r
 \r
 """;
+
     headers = new Map();
     headers["header-a"] = "AAA";
     headers["x-header-b"] = "bbb";
     _testParseRequest(request, "POST", "/test", expectedHeaders: headers);
 
     request = """
 POST /test HTTP/1.1\r
 Content-Length: 10\r
 \r
 0123456789""";
@@ skipping 451 matching lines @@
 0123456789012345678901234567890\r
 0\r\n\r\n""";
     _testParseInvalidResponse(response);
   }
 }
 
 
 void main() {
   HttpParserTest.runAllTests();
 }