Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1525593002: Introduce benign errors. (Closed)

Created:
5 years ago by Johnni Winther
Modified:
5 years ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -2 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 2 chunks +28 lines, -2 lines 0 comments Download
A tests/compiler/dart2js/benign_error_test.dart View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
5 years ago (2015-12-14 10:55:34 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1525593002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/1525593002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode1730 pkg/compiler/lib/src/compiler.dart:1730: (options.fatalWarnings && maybe benign errors should continue to ...
5 years ago (2015-12-15 00:51:40 UTC) #3
Johnni Winther
https://codereview.chromium.org/1525593002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/1525593002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode1730 pkg/compiler/lib/src/compiler.dart:1730: (options.fatalWarnings && On 2015/12/15 00:51:40, Siggi Cherem (dart-lang) wrote: ...
5 years ago (2015-12-15 09:04:20 UTC) #4
Johnni Winther
5 years ago (2015-12-15 09:17:29 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
6bb8cd8943850ffc8ea17299d210baee4ed0db49 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698