Refactor of BrowserDistribution.

chrome/installer/util/browser_distribution.h

Index: chrome/installer/util/browser_distribution.h
diff --git a/chrome/installer/util/browser_distribution.h b/chrome/installer/util/browser_distribution.h
index d1459ff04fcb6ec0b7e3c8e6d8dd33c44a90701e..a5e54d0c469cc58ffc284be47614da7b8146e8bf 100644
--- a/chrome/installer/util/browser_distribution.h
+++ b/chrome/installer/util/browser_distribution.h
@@ -29,6 +29,17 @@ class BrowserDistribution {
     NUM_TYPES
   };
 
+  enum ShortcutEnum {
+    SHORTCUT_CHROME,
+    SHORTCUT_ALTERNATE_CHROME,
+    SHORTCUT_APP_LAUNCHER
+  };
+
+  enum SubfolderEnum {
+    SUBFOLDER_CHROME,
+    SUBFOLDER_APPS

[gab, 2013/06/18 19:50:29]

SUBFOLDER_APPS is unused yet, only include it in the CL in which it will be used
(feel free to comment it out with a comment for now (instead of fully deleting
it... to avoid someone coming in and deleting this enum with a single
value...)).

[calamity, 2013/06/27 01:27:44]

Done.

+  };
+
   virtual ~BrowserDistribution() {}
 
   static BrowserDistribution* GetDistribution();
@@ -53,10 +64,16 @@ class BrowserDistribution {
   // at run-time.
   virtual string16 GetBaseAppName();
 
-  // Returns the localized name of the program.
-  virtual string16 GetAppShortCutName();
+  // Returns the display name of this distribution.
+  virtual string16 GetDisplayName();
 
-  virtual string16 GetAlternateApplicationName();
+  virtual string16 GetShortcutName(ShortcutEnum shortcut_enum);
+  virtual int GetIconIndex(ShortcutEnum shortcut_enum);
+  virtual string16 GetIconFilename();
+
+  // Returns the name of the subfolder in the Start Menu that this distribution
+  // should create shortcuts in.
+  virtual string16 GetStartMenuShortcutSubfolder(SubfolderEnum subfolder_enum);
 
   // Returns the unsuffixed appid of this program.
   // The AppUserModelId is a property of Windows programs.
@@ -96,13 +113,6 @@ class BrowserDistribution {
 
   virtual bool CanCreateDesktopShortcuts();
 
-  // Returns the executable filename (not path) that contains the product icon.
-  virtual string16 GetIconFilename();
-
-  // Returns the index of the icon for the product, inside the file specified by

[gab, 2013/06/18 19:50:29]

Keep these 2 method comments.

[calamity, 2013/06/27 01:27:44]

Done.

-  // GetIconFilename().
-  virtual int GetIconIndex();
-
   virtual bool GetChromeChannel(string16* channel);
 
   // Returns true if this distribution includes a DelegateExecute verb handler,