chrome/installer/util/google_chrome_distribution_dummy.cc - Issue 15255004: Refactor of BrowserDistribution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/google_chrome_distribution_dummy.cc

Issue 15255004: Refactor of BrowserDistribution. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rework Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/util/google_chrome_distribution_dummy.cc

diff --git a/chrome/installer/util/google_chrome_distribution_dummy.cc b/chrome/installer/util/google_chrome_distribution_dummy.cc

index 623870c7ea5f03f027effa9def816436a9a319ec..297403b03430dca35c94208cd88e0ceba161dced 100644

--- a/chrome/installer/util/google_chrome_distribution_dummy.cc

+++ b/chrome/installer/util/google_chrome_distribution_dummy.cc

@@ -41,14 +41,14 @@ string16 GoogleChromeDistribution::GetBaseAppName() {

return string16();

}

-string16 GoogleChromeDistribution::GetAppShortCutName() {

+string16 GoogleChromeDistribution::GetShortcutName(ShortcutEnum shortcut_enum) {

NOTREACHED();

return string16();

}

-string16 GoogleChromeDistribution::GetAlternateApplicationName() {

+int GoogleChromeDistribution::GetIconIndex(ShortcutEnum shortcut_enum) {

NOTREACHED();

- return string16();

+ return 0;

}

string16 GoogleChromeDistribution::GetBaseAppId() {