chrome/installer/util/chromium_binaries_distribution.h - Issue 15255004: Refactor of BrowserDistribution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/chromium_binaries_distribution.h

Issue 15255004: Refactor of BrowserDistribution. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rework Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/util/chromium_binaries_distribution.h

diff --git a/chrome/installer/util/chromium_binaries_distribution.h b/chrome/installer/util/chromium_binaries_distribution.h

index e78bf8654ef46569916ef8a253a236ad9c679319..10ce3d608616fb29a05fc3cd6b5a29076ccf7919 100644

--- a/chrome/installer/util/chromium_binaries_distribution.h

+++ b/chrome/installer/util/chromium_binaries_distribution.h

@@ -15,11 +15,13 @@ class ChromiumBinariesDistribution : public BrowserDistribution {

public:

virtual string16 GetAppGuid() OVERRIDE;

- virtual string16 GetBaseAppName() OVERRIDE;

+ virtual string16 GetDisplayName() OVERRIDE;

+ virtual string16 GetShortcutName(ShortcutEnum shortcut_enum) OVERRIDE;

- virtual string16 GetAppShortCutName() OVERRIDE;

+ virtual int GetIconIndex(ShortcutEnum shortcut_enum) OVERRIDE;

- virtual string16 GetAlternateApplicationName() OVERRIDE;

+ virtual string16 GetBaseAppName() OVERRIDE;

virtual string16 GetBaseAppId() OVERRIDE;

@@ -45,8 +47,6 @@ class ChromiumBinariesDistribution : public BrowserDistribution {

virtual bool CanSetAsDefault() OVERRIDE;

- virtual int GetIconIndex() OVERRIDE;

virtual bool GetChromeChannel(string16* channel) OVERRIDE;

virtual bool GetCommandExecuteImplClsid(