Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1835)

Unified Diff: chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc

Issue 15255004: Refactor of BrowserDistribution. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rework Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc
diff --git a/chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc b/chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc
index c918574a9e74c4be731f97df35bbcb1cdb8618c3..4762dc4e560bfb51246c53712656445d6a005311 100644
--- a/chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc
+++ b/chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc
@@ -222,7 +222,9 @@ class ProfileShortcutManagerTest : public testing::Test {
ShellUtil::SHELL_SHORTCUT_CREATE_ALWAYS)) << location.ToString();
const base::FilePath system_level_shortcut_path =
GetSystemShortcutsDirectory().Append(
- distribution->GetAppShortCutName() + installer::kLnkExt);
+ distribution->
+ GetShortcutName(BrowserDistribution::SHORTCUT_CHROME) +
+ installer::kLnkExt);
EXPECT_TRUE(file_util::PathExists(system_level_shortcut_path))
<< location.ToString();
return system_level_shortcut_path;
@@ -310,7 +312,8 @@ TEST_F(ProfileShortcutManagerTest, ShortcutFilenameStripsReservedCharacters) {
const string16 kSanitizedProfileName = L"Harry";
BrowserDistribution* distribution = GetDistribution();
const string16 expected_name = kSanitizedProfileName + L" - " +
- distribution->GetAppShortCutName() + installer::kLnkExt;
+ distribution->GetShortcutName(BrowserDistribution::SHORTCUT_CHROME) +
+ installer::kLnkExt;
EXPECT_EQ(expected_name,
profiles::internal::GetShortcutFilenameForProfile(kProfileName,
distribution));
@@ -318,9 +321,11 @@ TEST_F(ProfileShortcutManagerTest, ShortcutFilenameStripsReservedCharacters) {
TEST_F(ProfileShortcutManagerTest, UnbadgedShortcutFilename) {
BrowserDistribution* distribution = GetDistribution();
- EXPECT_EQ(distribution->GetAppShortCutName() + installer::kLnkExt,
- profiles::internal::GetShortcutFilenameForProfile(string16(),
- distribution));
+ EXPECT_EQ(
+ distribution->GetShortcutName(BrowserDistribution::SHORTCUT_CHROME) +
+ installer::kLnkExt,
+ profiles::internal::GetShortcutFilenameForProfile(string16(),
+ distribution));
}
TEST_F(ProfileShortcutManagerTest, ShortcutFlags) {
@@ -578,7 +583,8 @@ TEST_F(ProfileShortcutManagerTest, UpdateShortcutWithNoFlags) {
false));
const base::FilePath regular_shortcut_path =
CreateRegularShortcutWithName(FROM_HERE,
- GetDistribution()->GetAppShortCutName());
+ GetDistribution()->GetShortcutName(
+ BrowserDistribution::SHORTCUT_CHROME));
gab 2013/06/27 11:49:43 nit: Indent 4 more spaces.
calamity 2013/07/05 09:00:29 Done.
// Add another profile and check that the shortcut was replaced with
// a badged shortcut with the right command line for the profile
@@ -596,7 +602,8 @@ TEST_F(ProfileShortcutManagerTest, UpdateTwoShortcutsWithNoFlags) {
false));
const base::FilePath regular_shortcut_path =
CreateRegularShortcutWithName(FROM_HERE,
- GetDistribution()->GetAppShortCutName());
+ GetDistribution()->GetShortcutName(
+ BrowserDistribution::SHORTCUT_CHROME));
const base::FilePath customized_regular_shortcut_path =
CreateRegularShortcutWithName(FROM_HERE, L"MyChrome");
« no previous file with comments | « no previous file | chrome/browser/profiles/profile_shortcut_manager_win.cc » ('j') | chrome/installer/util/browser_distribution.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698