Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3773)

Unified Diff: chrome/installer/setup/uninstall.cc

Issue 15255004: Refactor of BrowserDistribution. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/uninstall.cc
diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc
index e86a867a5b08263144a847365d5a22ba84d734cc..f27ca863a3b77bfb01de89854a7138e3a2c0b731 100644
--- a/chrome/installer/setup/uninstall.cc
+++ b/chrome/installer/setup/uninstall.cc
@@ -101,7 +101,7 @@ void AddChannelValueUpdateWorkItems(
product_state != NULL && product_state->is_multi_install())
<< "Channel value for "
<< BrowserDistribution::GetSpecificDistribution(
- dist_type)->GetAppShortCutName()
+ dist_type)->GetDisplayName()
huangs 2013/05/21 21:35:41 I don't think we should localize our logs. Please
<< " is somehow already set to the desired new value of "
<< channel_info.value();
}
@@ -941,7 +941,7 @@ void UninstallActiveSetupEntries(const InstallerState& installer_state,
const char* install_level =
installer_state.system_install() ? "system" : "user";
VLOG(1) << "No Active Setup processing to do for " << install_level
- << "-level " << distribution->GetAppShortCutName();
+ << "-level " << distribution->GetDisplayName();
return;
}
@@ -1080,7 +1080,7 @@ InstallStatus UninstallProduct(const InstallationState& original_state,
bool is_chrome = product.is_chrome();
- VLOG(1) << "UninstallProduct: " << browser_dist->GetAppShortCutName();
+ VLOG(1) << "UninstallProduct: " << browser_dist->GetDisplayName();
if (force_uninstall) {
// Since --force-uninstall command line option is used, we are going to

Powered by Google App Engine
This is Rietveld 408576698