Introduce a mock ui_unittests Framework for loading resources.

ui/base/test/run_all_unittests.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/path_service.h"
 #include "base/test/launcher/unit_test_launcher.h"
 #include "base/test/test_suite.h"
 #include "build/build_config.h"
@@ skipping 36 matching lines @@
   // Register JNI bindings for android.
   gfx::android::RegisterJni(base::android::AttachCurrentThread());
   ui::android::RegisterJni(base::android::AttachCurrentThread());
 #endif
 
   ui::RegisterPathProvider();
   gfx::RegisterPathProvider();
 
 #if defined(OS_MACOSX) && !defined(OS_IOS)
   // Look in the framework bundle for resources.
-  // TODO(port): make a resource bundle for non-app exes.  What's done here
-  // isn't really right because this code needs to depend on chrome_dll
-  // being built.  This is inappropriate in app.
   base::FilePath path;
   PathService::Get(base::DIR_EXE, &path);
-#if defined(GOOGLE_CHROME_BUILD)
-  path = path.AppendASCII("Google Chrome Framework.framework");
-#elif defined(CHROMIUM_BUILD)
-  path = path.AppendASCII("Chromium Framework.framework");
-#else
-#error Unknown branding
-#endif
+  path = path.AppendASCII("ui_unittests Framework.framework");

[tfarina, 2014/02/07 01:06:27]

Can we get this chunk landed first (and separate) from the chunk below?

So we can see exactly what is (or not) necessary for mac?

[tfarina, 2014/02/07 03:57:24]

For reference, content_shell has a clean way to do this (imo):

https://chromium.googlesource.com/chromium/chromium/+/trunk/content/shell/app...

[tapted, 2014/02/28 08:10:56]

Since we know it's a test binary running we can simplify here. Otherwise these
lines should have the same effect as OverrideFrameworkBundlePath in that link

[tapted, 2014/02/28 08:10:56]

I've added another symlink in the Framework bundle so we can avoid the chunk
below on Mac. Haven't found a nice way to avoid it on other platforms, and there
were some other things missed that come up only when doing clobber builds.

   base::mac::SetOverrideFrameworkBundlePath(path);
 #endif  // defined(OS_MACOSX) && !defined(OS_IOS)
 
-  // TODO(tfarina): This loads chrome_100_percent.pak and thus introduces a
-  // dependency on chrome/, we don't want that here, so change this to
-  // InitSharedInstanceWithPakPath().
   ui::ResourceBundle::InitSharedInstanceWithLocale("en-US", NULL);
+
+  base::FilePath pak_dir;
+  PathService::Get(base::DIR_MODULE, &pak_dir);
+  base::FilePath pak_file;
+  pak_file = pak_dir.Append(FILE_PATH_LITERAL("ui_test.pak"));
+  ui::ResourceBundle::GetSharedInstance().AddDataPackFromPath(
+      pak_file, ui::SCALE_FACTOR_100P);
 }
 
 void UIBaseTestSuite::Shutdown() {
   ui::ResourceBundle::CleanupSharedInstance();
 
 #if defined(OS_MACOSX) && !defined(OS_IOS)
   base::mac::SetOverrideFrameworkBundle(NULL);
 #endif
   base::TestSuite::Shutdown();
 }
 
 }  // namespace
 
 int main(int argc, char** argv) {
   UIBaseTestSuite test_suite(argc, argv);
 
   return base::LaunchUnitTests(argc,
                                argv,
                                base::Bind(&UIBaseTestSuite::Run,
                                           base::Unretained(&test_suite)));
 }