Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1525423002: Handle malformed elements in onElementResolved. (Closed)

Created:
5 years ago by Johnni Winther
Modified:
5 years ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -30 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 1 1 chunk +6 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/analyze_all_test.dart View 1 2 chunks +86 lines, -30 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
5 years ago (2015-12-16 12:31:16 UTC) #2
sigurdm
LGTM https://codereview.chromium.org/1525423002/diff/1/pkg/compiler/lib/src/js_backend/backend.dart File pkg/compiler/lib/src/js_backend/backend.dart (right): https://codereview.chromium.org/1525423002/diff/1/pkg/compiler/lib/src/js_backend/backend.dart#newcode2428 pkg/compiler/lib/src/js_backend/backend.dart:2428: if (element.isMalformed) return; Add comment when this can ...
5 years ago (2015-12-16 13:20:38 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as 5d53b301514ed5c04ba2bdf5298b1787f961aca9 (presubmit successful).
5 years ago (2015-12-16 14:04:35 UTC) #5
Johnni Winther
5 years ago (2015-12-18 13:28:17 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1525423002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/1525423002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/backend.dart:2428: if (element.isMalformed)
return;
On 2015/12/16 13:20:38, sigurdm wrote:
> Add comment when this can happen

Done.

https://codereview.chromium.org/1525423002/diff/1/tests/compiler/dart2js/anal...
File tests/compiler/dart2js/analyze_all_test.dart (right):

https://codereview.chromium.org/1525423002/diff/1/tests/compiler/dart2js/anal...
tests/compiler/dart2js/analyze_all_test.dart:80: test3() async {
On 2015/12/16 13:20:38, sigurdm wrote:
> Maybe add a comment that this is a regression test, testing that ...

Done.

Powered by Google App Engine
This is Rietveld 408576698