Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1525413003: Update MIPS owners. (Closed)

Created:
5 years ago by paul.l...
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update MIPS owners. Add Ivica B. NOTRY=true Committed: https://crrev.com/a0c7e25f993abb87af87674863686a065bb0273a Cr-Commit-Position: refs/heads/master@{#32933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M src/compiler/mips/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips64/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/mips/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/mips64/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M src/debug/mips/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M src/debug/mips64/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/mips/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/mips64/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/mips/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/mips64/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M src/regexp/mips/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M src/regexp/mips64/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/mips/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/mips64/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
paul.l...
PTAL, Michael, I will need your team's approval for the cctest/OWNERS at the least, maybe ...
5 years ago (2015-12-16 20:29:35 UTC) #2
Jakob Kummerow
lgtm
5 years ago (2015-12-17 08:47:38 UTC) #3
Jakob Kummerow
I've added NOTRY=true, no need to spend trybot CPU cycles on this, presubmit is enough.
5 years ago (2015-12-17 08:49:01 UTC) #5
Michael Hablich
lgtm, cctest is also ok because it only adds him as an owner for MIPS ...
5 years ago (2015-12-17 09:04:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525413003/1
5 years ago (2015-12-17 09:04:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 09:06:12 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-17 09:07:08 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0c7e25f993abb87af87674863686a065bb0273a
Cr-Commit-Position: refs/heads/master@{#32933}

Powered by Google App Engine
This is Rietveld 408576698