Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 1525223002: [Android] Fix to add javacutil jar as build dep to errorprone. (Closed)

Created:
5 years ago by mikecase (-- gone --)
Modified:
5 years ago
Reviewers:
jbudorick
CC:
chromium-reviews, aberent
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix to add javacutil jar as build dep to errorprone. BUG=569547 Committed: https://crrev.com/efb18a9e4e08091d95ea0427297310e965934c92 Cr-Commit-Position: refs/heads/master@{#365851}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M third_party/errorprone/BUILD.gn View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/errorprone/errorprone.gyp View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mikecase (-- gone --)
This change should fix https://code.google.com/p/chromium/issues/detail?id=569547 I guess when I set up errorprone I had added ...
5 years ago (2015-12-15 17:52:41 UTC) #2
jbudorick
lgtm
5 years ago (2015-12-15 23:37:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525223002/1
5 years ago (2015-12-16 00:40:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on ...
5 years ago (2015-12-16 02:48:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525223002/1
5 years ago (2015-12-17 17:20:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 17:57:03 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-17 17:57:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efb18a9e4e08091d95ea0427297310e965934c92
Cr-Commit-Position: refs/heads/master@{#365851}

Powered by Google App Engine
This is Rietveld 408576698