Shrink SVGTransform::valueAsString

Shrink SVGTransform::valueAsString

Use a StringBuilder and convert transformTypePrefixForParsing to return
const char*.
Since this is a uniform arguments notation, put the arguments in an
array and loop through them, appending them to the result.
This reduces the size of this method from a bit of 6k to a bit over 950
bytes (x86-64).

Committed: https://crrev.com/8b082d0c40be97848889cb3a0a42294042aee9dd
Cr-Commit-Position: refs/heads/master@{#365354}

[fs, 2015-12-15 19:16:57]

Description was changed from

==========
Shrink SVGTransform::valueAsString

Use a StringBuilder and convert transformTypePrefixForParsing to return
const char*.
Since this is a uniform arguments notation, put the arguments in an
array and loop through them, appending them to the result.
This reduces the size of this method from a bit of 6k to a bit over 900
bytes (x86-64).
==========

to

==========
Shrink SVGTransform::valueAsString

Use a StringBuilder and convert transformTypePrefixForParsing to return
const char*.
Since this is a uniform arguments notation, put the arguments in an
array and loop through them, appending them to the result.
This reduces the size of this method from a bit of 6k to a bit over 950
bytes (x86-64).
==========

[fs, 2015-12-15 19:18:28]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[fs, 2015-12-15 19:18:28]

More size-reducing whistle fodder

[pdr., 2015-12-15 19:26:25]

https://codereview.chromium.org/1525213002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGTransform.cpp (right):

https://codereview.chromium.org/1525213002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGTransform.cpp:180: double arguments[6];
Why store these off in a separate array instead of just doing this?
stringBuilder.appendNumber(m_matrix.x());
stringBuilder.append(' ');

[fs, 2015-12-15 19:39:35]

Patchset #4 (id:60001) has been deleted

[fs, 2015-12-15 19:42:58]

https://codereview.chromium.org/1525213002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGTransform.cpp (right):

https://codereview.chromium.org/1525213002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGTransform.cpp:180: double arguments[6];
On 2015/12/15 at 19:26:25, pdr wrote:
> Why store these off in a separate array instead of just doing this?
> stringBuilder.appendNumber(m_matrix.x());
> stringBuilder.append(' ');

All the append(' ')'s result in quite significant bloat (almost doubling the
size.)

[pdr., 2015-12-15 21:38:03]

On 2015/12/15 at 19:42:58, fs wrote:
>
https://codereview.chromium.org/1525213002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/svg/SVGTransform.cpp (right):
> 
>
https://codereview.chromium.org/1525213002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/svg/SVGTransform.cpp:180: double arguments[6];
> On 2015/12/15 at 19:26:25, pdr wrote:
> > Why store these off in a separate array instead of just doing this?
> > stringBuilder.appendNumber(m_matrix.x());
> > stringBuilder.append(' ');
> 
> All the append(' ')'s result in quite significant bloat (almost doubling the
size.)

Ok, LGTM

[pdr., 2015-12-15 21:38:07]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2015-12-15 21:40:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1525213002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1525213002/40001

[commit-bot: I haz the power, 2015-12-15 22:08:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-15 22:10:25]

Description was changed from

==========
Shrink SVGTransform::valueAsString

Use a StringBuilder and convert transformTypePrefixForParsing to return
const char*.
Since this is a uniform arguments notation, put the arguments in an
array and loop through them, appending them to the result.
This reduces the size of this method from a bit of 6k to a bit over 950
bytes (x86-64).
==========

to

==========
Shrink SVGTransform::valueAsString

Use a StringBuilder and convert transformTypePrefixForParsing to return
const char*.
Since this is a uniform arguments notation, put the arguments in an
array and loop through them, appending them to the result.
This reduces the size of this method from a bit of 6k to a bit over 950
bytes (x86-64).

Committed: https://crrev.com/8b082d0c40be97848889cb3a0a42294042aee9dd
Cr-Commit-Position: refs/heads/master@{#365354}
==========

[commit-bot: I haz the power, 2015-12-15 22:10:25]

Patchset 3 (id:??) landed as
https://crrev.com/8b082d0c40be97848889cb3a0a42294042aee9dd
Cr-Commit-Position: refs/heads/master@{#365354}