tools/gn/input_conversion_unittest.cc - Issue 1525183002: tools/gn: rename char_offset to column_number

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/input_conversion_unittest.cc

Issue 1525183002: tools/gn: rename char_offset to column_number (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix indentation Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/input_conversion_unittest.cc

diff --git a/tools/gn/input_conversion_unittest.cc b/tools/gn/input_conversion_unittest.cc

index aff66674172f37dda1bf5e34331e4e94850ee07b..2c4afeacc6b0ac952b750e278f5cb9b73004c66a 100644

--- a/tools/gn/input_conversion_unittest.cc

+++ b/tools/gn/input_conversion_unittest.cc

@@ -126,7 +126,7 @@ TEST_F(InputConversionTest, ValueDict) {

ASSERT_TRUE(a_origin);

LocationRange a_range = a_origin->GetRange();

EXPECT_EQ(2, a_range.begin().line_number());

- EXPECT_EQ(6, a_range.begin().char_offset());

+ EXPECT_EQ(6, a_range.begin().column_number());

const InputFile* a_file = a_range.begin().file();

EXPECT_EQ(input, a_file->contents());

« no previous file with comments | « tools/gn/header_checker.cc ('k') | tools/gn/location.h » ('j') | no next file with comments »