Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Side by Side Diff: test/mjsunit/debug-step.js

Issue 1525173003: [debugger] remove step count parameter from prepare step. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 19 matching lines...) Expand all
30 Debug = debug.Debug 30 Debug = debug.Debug
31 31
32 // Simple debug event handler which first time hit will perform 1000 steps and 32 // Simple debug event handler which first time hit will perform 1000 steps and
33 // second time hit will evaluate and store the value of "i". If requires that 33 // second time hit will evaluate and store the value of "i". If requires that
34 // the global property "state" is initially zero. 34 // the global property "state" is initially zero.
35 35
36 var bp1, bp2; 36 var bp1, bp2;
37 37
38 function listener(event, exec_state, event_data, data) { 38 function listener(event, exec_state, event_data, data) {
39 if (event == Debug.DebugEvent.Break) { 39 if (event == Debug.DebugEvent.Break) {
40 if (state == 0) { 40 if (step_count > 0) {
41 exec_state.prepareStep(Debug.StepAction.StepIn, 1000); 41 exec_state.prepareStep(Debug.StepAction.StepIn);
42 state = 1; 42 step_count--;
43 } else if (state == 1) { 43 } else {
44 result = exec_state.frame().evaluate("i").value(); 44 result = exec_state.frame().evaluate("i").value();
45 // Clear the break point on line 2 if set. 45 // Clear the break point on line 2 if set.
46 if (bp2) { 46 if (bp2) {
47 Debug.clearBreakPoint(bp2); 47 Debug.clearBreakPoint(bp2);
48 } 48 }
49 } 49 }
50 } 50 }
51 }; 51 };
52 52
53 // Add the debug event listener. 53 // Add the debug event listener.
54 Debug.setListener(listener); 54 Debug.setListener(listener);
55 55
56 // Test debug event for break point. 56 // Test debug event for break point.
57 function f() { 57 function f() {
58 var i; // Line 1. 58 var i; // Line 1.
59 for (i = 0; i < 1000; i++) { // Line 2. 59 for (i = 0; i < 1000; i++) { // Line 2.
60 x = 1; // Line 3. 60 x = 1; // Line 3.
61 } 61 }
62 }; 62 };
63 63
64 // Set a breakpoint on the for statement (line 1). 64 // Set a breakpoint on the for statement (line 1).
65 bp1 = Debug.setBreakPoint(f, 1); 65 bp1 = Debug.setBreakPoint(f, 1);
66 66
67 // Check that performing 1000 steps will make i 499. 67 // Check that performing 1000 steps will make i 499.
68 state = 0; 68 var step_count = 1000;
69 result = -1; 69 result = -1;
70 f(); 70 f();
71 assertEquals(332, result); 71 assertEquals(332, result);
72
73 // Check that performing 1000 steps with a break point on the statement in the
74 // for loop (line 2) will only make i 0 as a real break point breaks even when
75 // multiple steps have been requested.
76 state = 0;
77 result = -1;
78 bp2 = Debug.setBreakPoint(f, 3);
79 f();
80 assertEquals(0, result);
81
82 // Get rid of the debug event listener.
83 Debug.setListener(null); 72 Debug.setListener(null);
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698