Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: gyp/giflib.gyp

Issue 152513007: Build Skia for a bare-bones embedded Linux system. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gyp/giflib.gyp
diff --git a/gyp/giflib.gyp b/gyp/giflib.gyp
new file mode 100644
index 0000000000000000000000000000000000000000..ea6a7eb00a158b7926322ff66af21a89585dd038
--- /dev/null
+++ b/gyp/giflib.gyp
@@ -0,0 +1,62 @@
+# Copyright 2014 Google Inc.
+#
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+{
+ 'conditions': [
djsollen 2014/02/06 16:24:34 I'm not a big fan of defining each target 2x. Why
hal.canary 2014/02/06 18:01:57 Done.
+ ['skia_giflib_static', {
+ 'variables': {
+ 'skia_warnings_as_errors': 0,
+ },
+ 'targets': [
+ {
+ 'target_name': 'giflib',
+ 'type': 'static_library',
+ 'defines': [
+ 'HAVE_CONFIG_H',
+ ],
+ 'include_dirs': [
+ '../third_party/externals/giflib',
+ ],
+ 'dependencies': [
+ ],
+ 'direct_dependent_settings': {
+ 'include_dirs': [
+ '../third_party/externals/giflib',
+ ],
+ },
+ 'export_dependent_settings': [
+ ],
+ 'cflags': [
+ '-w',
+ ],
+ 'link_settings': {
+ 'libraries': [
scroggo 2014/02/06 16:22:13 If this is correctly empty, it can be removed.
hal.canary 2014/02/06 18:01:57 Done.
+ ],
+ },
+ 'sources': [
+ '../third_party/externals/giflib/dgif_lib.c',
+ '../third_party/externals/giflib/gifalloc.c',
+ '../third_party/externals/giflib/gif_err.c',
+ ],
+ },
+ ],
+ }, {
scroggo 2014/02/06 16:22:13 I assume this is if 'skia_giflib_static' is false?
hal.canary 2014/02/06 18:01:57 Done.
scroggo 2014/02/06 18:14:50 This seems to still be missing
+ 'targets': [
+ {
+ 'target_name': 'giflib',
+ 'type': 'none',
+ 'direct_dependent_settings': {
+ 'link_settings': {
+ 'libraries': [
+ '-lgif',
+ ],
+ }
+ }
+ }
+ ]
+ }]
+ ]
+}
+

Powered by Google App Engine
This is Rietveld 408576698