gyp/giflib.gyp - Issue 152513007: Build Skia for a bare-bones embedded Linux system.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gyp/giflib.gyp

Issue 152513007: Build Skia for a bare-bones embedded Linux system. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2014 Google Inc.

	2 #

	3 # Use of this source code is governed by a BSD-style license that can be

	4 # found in the LICENSE file.

	5

	6 {

	7 'conditions': [
	djsollen 2014/02/06 16:24:34 I'm not a big fan of defining each target 2x. Why I'm not a big fan of defining each target 2x. Why not have one target with the condition that contains all differences? Same goes for all the other files you added. hal.canary 2014/02/06 18:01:57 Done. Show quoted text On 2014/02/06 16:24:34, djsollen wrote: > I'm not a big fan of defining each target 2x. Why not have one target with the > condition that contains all differences? Same goes for all the other files you > added. Done.
	8 ['skia_giflib_static', {

	9 'variables': {

	10 'skia_warnings_as_errors': 0,

	11 },

	12 'targets': [

	13 {

	14 'target_name': 'giflib',

	15 'type': 'static_library',

	16 'defines': [

	17 'HAVE_CONFIG_H',

	18 ],

	19 'include_dirs': [

	20 '../third_party/externals/giflib',

	21 ],

	22 'dependencies': [

	23 ],

	24 'direct_dependent_settings': {

	25 'include_dirs': [

	26 '../third_party/externals/giflib',

	27 ],

	28 },

	29 'export_dependent_settings': [

	30 ],

	31 'cflags': [

	32 '-w',

	33 ],

	34 'link_settings': {

	35 'libraries': [
	scroggo 2014/02/06 16:22:13 If this is correctly empty, it can be removed. If this is correctly empty, it can be removed. hal.canary 2014/02/06 18:01:57 Done. Show quoted text On 2014/02/06 16:22:13, scroggo wrote: > If this is correctly empty, it can be removed. Done.
	36 ],

	37 },

	38 'sources': [

	39 '../third_party/externals/giflib/dgif_lib.c',

	40 '../third_party/externals/giflib/gifalloc.c',

	41 '../third_party/externals/giflib/gif_err.c',

	42 ],

	43 },

	44 ],

	45 }, {
	scroggo 2014/02/06 16:22:13 I assume this is if 'skia_giflib_static' is false? I assume this is if 'skia_giflib_static' is false? Can you add a comment here reflecting that? It can be hard to visually grasp a gyp file, with its several layers of brackets and braces. hal.canary 2014/02/06 18:01:57 Done. Show quoted text On 2014/02/06 16:22:13, scroggo wrote: > I assume this is if 'skia_giflib_static' is false? Can you add a comment here > reflecting that? It can be hard to visually grasp a gyp file, with its several > layers of brackets and braces. Done. scroggo 2014/02/06 18:14:50 This seems to still be missing Show quoted text On 2014/02/06 18:01:57, Hal Canary wrote: > On 2014/02/06 16:22:13, scroggo wrote: > > I assume this is if 'skia_giflib_static' is false? Can you add a comment here > > reflecting that? It can be hard to visually grasp a gyp file, with its several > > layers of brackets and braces. > > Done. This seems to still be missing
	46 'targets': [

	47 {

	48 'target_name': 'giflib',

	49 'type': 'none',

	50 'direct_dependent_settings': {

	51 'link_settings': {

	52 'libraries': [

	53 '-lgif',

	54 ],

	55 }

	56 }

	57 }

	58 ]

	59 }]

	60 ]

	61 }

	62

OLD	NEW

« gyp/freetype.gyp ('K') | « gyp/freetype.gyp ('k') | gyp/images.gyp » ('j') | gyp/images.gyp » ('J')