Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 152513002: Files.app: Fix the number of remaining files and processed bytes. (Closed)

Created:
6 years, 10 months ago by hirono
Modified:
6 years, 10 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Files.app: Fix the number of remaining files and processed bytes. A part of code of FileOperationManager aims to recursive operations in order to obtain the detailed progress. But the recursive operations is not implemented now. The code caused bugs of wrong progress bytes and remaining file count. This CL fixes the bug. BUG=340180 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248855

Patch Set 1 : #

Patch Set 2 : Make it simpler #

Total comments: 4

Patch Set 3 : Fixed. #

Patch Set 4 : Fixed a test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -48 lines) Patch
M chrome/browser/resources/file_manager/background/js/file_operation_handler.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/file_manager/background/js/file_operation_manager.js View 1 2 5 chunks +30 lines, -45 lines 0 comments Download
M chrome/test/data/file_manager/unit_tests/file_operation_handler_unittest.js View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 37 (0 generated)
hirono
PTAL the CL? Thanks!
6 years, 10 months ago (2014-02-03 07:11:57 UTC) #1
yoshiki
lgtm https://codereview.chromium.org/152513002/diff/60001/chrome/browser/resources/file_manager/background/js/file_operation_manager.js File chrome/browser/resources/file_manager/background/js/file_operation_manager.js (right): https://codereview.chromium.org/152513002/diff/60001/chrome/browser/resources/file_manager/background/js/file_operation_manager.js#newcode483 chrome/browser/resources/file_manager/background/js/file_operation_manager.js:483: operationType: this.operationType, nit: 4 space indent https://codereview.chromium.org/152513002/diff/60001/chrome/browser/resources/file_manager/background/js/file_operation_manager.js#newcode504 chrome/browser/resources/file_manager/background/js/file_operation_manager.js:504: ...
6 years, 10 months ago (2014-02-03 09:51:02 UTC) #2
hirono
Thanks! https://codereview.chromium.org/152513002/diff/60001/chrome/browser/resources/file_manager/background/js/file_operation_manager.js File chrome/browser/resources/file_manager/background/js/file_operation_manager.js (right): https://codereview.chromium.org/152513002/diff/60001/chrome/browser/resources/file_manager/background/js/file_operation_manager.js#newcode483 chrome/browser/resources/file_manager/background/js/file_operation_manager.js:483: operationType: this.operationType, On 2014/02/03 09:51:03, yoshiki wrote: > ...
6 years, 10 months ago (2014-02-03 10:40:17 UTC) #3
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-03 10:40:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/152513002/120001
6 years, 10 months ago (2014-02-03 10:40:39 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-03 11:14:34 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) check_deps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=222178
6 years, 10 months ago (2014-02-03 11:14:35 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 11:14:36 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 11:14:38 UTC) #9
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-04 04:56:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/152513002/390001
6 years, 10 months ago (2014-02-04 04:58:16 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 05:38:02 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=222787
6 years, 10 months ago (2014-02-04 05:38:02 UTC) #13
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-04 05:54:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/152513002/390001
6 years, 10 months ago (2014-02-04 05:54:50 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 07:05:55 UTC) #16
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120522
6 years, 10 months ago (2014-02-04 07:05:56 UTC) #17
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-04 07:10:34 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/152513002/390001
6 years, 10 months ago (2014-02-04 07:12:13 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 08:13:30 UTC) #20
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120569
6 years, 10 months ago (2014-02-04 08:13:30 UTC) #21
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-04 08:23:52 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/152513002/390001
6 years, 10 months ago (2014-02-04 08:24:32 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 09:24:54 UTC) #24
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120613
6 years, 10 months ago (2014-02-04 09:24:55 UTC) #25
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-04 12:36:43 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/152513002/390001
6 years, 10 months ago (2014-02-04 12:37:20 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 13:35:42 UTC) #28
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120752
6 years, 10 months ago (2014-02-04 13:35:43 UTC) #29
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-04 15:02:52 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/152513002/390001
6 years, 10 months ago (2014-02-04 15:04:13 UTC) #31
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 16:09:06 UTC) #32
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120856
6 years, 10 months ago (2014-02-04 16:09:07 UTC) #33
skia-commit-bot
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 16:09:15 UTC) #34
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-05 02:38:34 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/152513002/390001
6 years, 10 months ago (2014-02-05 03:44:36 UTC) #36
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 05:17:51 UTC) #37
Message was sent while issue was closed. 
Change committed as 248855

Powered by Google App Engine
This is Rietveld 408576698