Issue 1525103002: Disable support for swapped out RenderFrame(Host)s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1525103002: Disable support for swapped out RenderFrame(Host)s (Closed)

Created:
5 years ago by Charlie Reis

Modified:
4 years, 12 months ago

Reviewers:

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable support for swapped out RenderFrame(Host)s Various bugs have been fixed since the last attempt. This is necessary for supporting out-of-process iframes. This also removes a sanity check in UpdateState which can no longer be computed, since the main frame RFH is not around when the IPC arrives. BUG=357747 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -6 lines)			Patch
	M	content/browser/web_contents/web_contents_impl.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
	M	content/common/site_isolation_policy.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Charlie Reis

4 years, 12 months ago (2015-12-26 23:32:59 UTC) #1

Description was changed from

==========
Disable support for swapped out RenderFrame(Host)s

Various bugs have been fixed since the last attempt.  This is necessary
for supporting out-of-process iframes.

This also removes a sanity check in UpdateState which can no longer be
computed, since the main frame RFH is not around when the IPC arrives.

BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Disable support for swapped out RenderFrame(Host)s

Various bugs have been fixed since the last attempt.  This is necessary
for supporting out-of-process iframes.

This also removes a sanity check in UpdateState which can no longer be
computed, since the main frame RFH is not around when the IPC arrives.

BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages