Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 1525033002: Add required_initial_confidence to legacy bisect. (Closed)

Created:
5 years ago by qyearsley
Modified:
5 years ago
Reviewers:
RobertoCN, prasadv, rmcilroy
CC:
chromium-reviews, auto-bisect-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add required_initial_confidence to legacy bisect. This should allow the "bypass no-repro check" button to work immediately for android and clank bisects. BUG=568041 Committed: https://crrev.com/c4bfff28cfbf2944bebc0ee5db6bbd5f1680ec9d Cr-Commit-Position: refs/heads/master@{#365394}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -11 lines) Patch
M tools/auto_bisect/bisect_perf_regression.py View 6 chunks +14 lines, -7 lines 0 comments Download
M tools/auto_bisect/bisect_perf_regression_test.py View 4 chunks +13 lines, -4 lines 0 comments Download
M tools/run-bisect-perf-regression.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
qyearsley
5 years ago (2015-12-15 00:29:01 UTC) #2
RobertoCN
lgtm
5 years ago (2015-12-15 20:01:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525033002/1
5 years ago (2015-12-15 20:12:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/129164)
5 years ago (2015-12-15 20:51:26 UTC) #7
qyearsley
On 2015/12/15 20:51:26, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years ago (2015-12-15 21:32:32 UTC) #11
rmcilroy
RSLGTM
5 years ago (2015-12-15 22:37:57 UTC) #12
rmcilroy
RS LGTM even
5 years ago (2015-12-15 22:38:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525033002/1
5 years ago (2015-12-15 23:13:59 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 23:42:23 UTC) #17
commit-bot: I haz the power
5 years ago (2015-12-15 23:43:10 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4bfff28cfbf2944bebc0ee5db6bbd5f1680ec9d
Cr-Commit-Position: refs/heads/master@{#365394}

Powered by Google App Engine
This is Rietveld 408576698