 Chromium Code Reviews
 Chromium Code Reviews Issue 1525023003:
  Distinguish in the browser between renderer crashes and kills  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1525023003:
  Distinguish in the browser between renderer crashes and kills  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: android_webview/browser/aw_content_browser_client.cc | 
| diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc | 
| index 573e2416297bdfbee1162d2bfb320b94748c796f..64922f2ee69eaa63513fb381def3c04e9098a8cd 100644 | 
| --- a/android_webview/browser/aw_content_browser_client.cc | 
| +++ b/android_webview/browser/aw_content_browser_client.cc | 
| @@ -24,8 +24,10 @@ | 
| #include "base/android/locale_utils.h" | 
| #include "base/base_paths_android.h" | 
| #include "base/command_line.h" | 
| +#include "base/files/scoped_file.h" | 
| #include "base/path_service.h" | 
| #include "components/cdm/browser/cdm_message_filter_android.h" | 
| +#include "components/crash/content/browser/crash_micro_dump_manager_android.h" | 
| #include "components/navigation_interception/intercept_navigation_delegate.h" | 
| #include "content/public/browser/access_token_store.h" | 
| #include "content/public/browser/browser_message_filter.h" | 
| @@ -485,6 +487,14 @@ void AwContentBrowserClient::GetAdditionalMappedFilesForChildProcess( | 
| fd = ui::GetLocalePackFd(&(*regions)[kAndroidWebViewLocalePakDescriptor]); | 
| mappings->Share(kAndroidWebViewLocalePakDescriptor, fd); | 
| + | 
| + base::File crash_signal_file = | 
| + breakpad::CrashMicroDumpManager::GetInstance()->CreateCrashInfoChannel( | 
| + child_process_id); | 
| + if (crash_signal_file.IsValid()) { | 
| 
Torne
2015/12/16 14:48:35
Is this ever expected to not be valid?
 
mnaganov (inactive)
2015/12/16 19:10:12
If socket pair creation fails, I suppose.
 | 
| + mappings->Transfer(kAndroidWebViewCrashSignalDescriptor, | 
| + base::ScopedFD(crash_signal_file.TakePlatformFile())); | 
| + } | 
| } | 
| void AwContentBrowserClient::OverrideWebkitPrefs( |