Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4722)

Unified Diff: android_webview/lib/main/aw_main_delegate.cc

Issue 1525023003: Distinguish in the browser between renderer crashes and kills (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove std::move for a value in return Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/crash_reporter/aw_microdump_crash_reporter.cc ('k') | components/crash.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/lib/main/aw_main_delegate.cc
diff --git a/android_webview/lib/main/aw_main_delegate.cc b/android_webview/lib/main/aw_main_delegate.cc
index c9340ff867e31a1290abfa148eb5f25f4b189a2f..70256872582d20a6f5a000fb0a90baaa7f069384 100644
--- a/android_webview/lib/main/aw_main_delegate.cc
+++ b/android_webview/lib/main/aw_main_delegate.cc
@@ -141,6 +141,7 @@ bool AwMainDelegate::BasicStartupComplete(int* exit_code) {
if (cl->HasSwitch(switches::kWebViewSandboxedRenderer)) {
cl->AppendSwitch(switches::kInProcessGPU);
cl->AppendSwitchASCII(switches::kRendererProcessLimit, "1");
+ cl->AppendSwitch(switches::kDisableRendererBackgrounding);
}
return false;
@@ -157,6 +158,7 @@ void AwMainDelegate::PreSandboxStartup() {
*base::CommandLine::ForCurrentProcess();
std::string process_type =
command_line.GetSwitchValueASCII(switches::kProcessType);
+ int crash_signal_fd = -1;
if (process_type == switches::kRendererProcess) {
auto global_descriptors = base::GlobalDescriptors::GetInstance();
int pak_fd = global_descriptors->Get(kAndroidWebViewLocalePakDescriptor);
@@ -169,6 +171,8 @@ void AwMainDelegate::PreSandboxStartup() {
global_descriptors->GetRegion(kAndroidWebViewMainPakDescriptor);
ResourceBundle::GetSharedInstance().AddDataPackFromFileRegion(
base::File(pak_fd), pak_region, ui::SCALE_FACTOR_NONE);
+ crash_signal_fd =
+ global_descriptors->Get(kAndroidWebViewCrashSignalDescriptor);
}
if (process_type.empty() &&
command_line.HasSwitch(switches::kSingleProcess)) {
@@ -176,7 +180,7 @@ void AwMainDelegate::PreSandboxStartup() {
process_type = "webview";
}
- crash_reporter::EnableMicrodumpCrashReporter(process_type);
+ crash_reporter::EnableMicrodumpCrashReporter(process_type, crash_signal_fd);
}
int AwMainDelegate::RunProcess(
« no previous file with comments | « android_webview/crash_reporter/aw_microdump_crash_reporter.cc ('k') | components/crash.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698