android_webview/browser/aw_browser_main_parts.cc - Issue 1525023003: Distinguish in the browser between renderer crashes and kills

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_browser_main_parts.cc

Issue 1525023003: Distinguish in the browser between renderer crashes and kills (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Torne's comment addressed Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/aw_browser_main_parts.h ('k') | android_webview/browser/aw_content_browser_client.cc » ('j') | components/crash/content/browser/crash_micro_dump_manager_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/aw_browser_main_parts.cc

diff --git a/android_webview/browser/aw_browser_main_parts.cc b/android_webview/browser/aw_browser_main_parts.cc

index d0fe336c15ed164d5b7f7a7e3ae40979124e90ee..8d09c8110efd97dbe911da239d037dd1fdffea8e 100644

--- a/android_webview/browser/aw_browser_main_parts.cc

+++ b/android_webview/browser/aw_browser_main_parts.cc

@@ -18,6 +18,7 @@

#include "base/command_line.h"

#include "base/files/file_path.h"

#include "base/path_service.h"

+#include "components/crash/content/browser/crash_micro_dump_manager_android.h"

#include "content/public/browser/android/synchronous_compositor.h"

#include "content/public/browser/render_frame_host.h"

#include "content/public/browser/render_process_host.h"

@@ -75,6 +76,10 @@ int AwBrowserMainParts::PreCreateThreads() {

base::android::MemoryPressureListenerAndroid::RegisterSystemCallback(

base::android::AttachCurrentThread());

DeferredGpuCommandService::SetInstance();

+ if (!base::CommandLine::ForCurrentProcess()->HasSwitch(

+ switches::kSingleProcess)) {

+ crash_micro_dump_manager_.reset(new breakpad::CrashMicroDumpManager());

+ }

return content::RESULT_CODE_NORMAL_EXIT;

}