Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 152493003: Remove all usage of -webkit-*gradient inside blink (Closed)

Created:
6 years, 10 months ago by Julien - ping for review
Modified:
6 years, 10 months ago
CC:
blink-reviews, devtools-reviews_chromium.org, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, ed+blinkwatch_opera.com, lushnikov+blink_chromium.org, yurys+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, darktears, aandrey+blink_chromium.org
Visibility:
Public.

Description

Remove all usage of -webkit-*gradient inside blink The prefixed functions have been deprecated in 2011 and should be use counted with the goal of removing them. This patch just rewrites existing rules on top of the modern syntax: -webkit-gradient(linear, top left, bottom left, from(white), to(black)) is equivalent to linear-gradient(to bottom, white, black) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166426

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -71 lines) Patch
M Source/core/css/html.css View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/TimelinePresentationModel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/auditsPanel.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/cssNamedFlows.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/dataGrid.css View 1 chunk +1 line, -1 line 2 comments Download
M Source/devtools/front_end/dialog.css View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/helpScreen.css View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/devtools/front_end/inspector.css View 13 chunks +24 lines, -24 lines 0 comments Download
M Source/devtools/front_end/networkPanel.css View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/devtools/front_end/panelEnablerView.css View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/devtools/front_end/resourcesPanel.css View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/spectrum.css View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/resources/pickerButton.css View 2 chunks +4 lines, -4 lines 0 comments Download
M Tools/GardeningServer/styles/common.css View 3 chunks +3 lines, -3 lines 0 comments Download
M Tools/GardeningServer/styles/main.css View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Julien - ping for review
@pfeldman: For the inspector/ bits @abarth: For web/ bits @morrita: For the core bits @ojan: ...
6 years, 10 months ago (2014-02-04 05:07:34 UTC) #1
abarth-chromium
Source/web LGTM
6 years, 10 months ago (2014-02-04 05:45:22 UTC) #2
pfeldman
lgtm
6 years, 10 months ago (2014-02-04 09:08:29 UTC) #3
ojan
lgtm
6 years, 10 months ago (2014-02-04 18:09:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/152493003/1
6 years, 10 months ago (2014-02-04 18:09:21 UTC) #5
commit-bot: I haz the power
Change committed as 166426
6 years, 10 months ago (2014-02-04 18:59:26 UTC) #6
eustas
https://codereview.chromium.org/152493003/diff/1/Source/devtools/front_end/dataGrid.css File Source/devtools/front_end/dataGrid.css (right): https://codereview.chromium.org/152493003/diff/1/Source/devtools/front_end/dataGrid.css#newcode87 Source/devtools/front_end/dataGrid.css:87: background-image: linear-gradient(linear, to bottom, white, white 50%, rgb(234, 243, ...
6 years, 10 months ago (2014-02-05 14:38:59 UTC) #7
Julien - ping for review
6 years, 10 months ago (2014-02-05 17:16:31 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/152493003/diff/1/Source/devtools/front_end/da...
File Source/devtools/front_end/dataGrid.css (right):

https://codereview.chromium.org/152493003/diff/1/Source/devtools/front_end/da...
Source/devtools/front_end/dataGrid.css:87: background-image:
linear-gradient(linear, to bottom, white, white 50%, rgb(234, 243, 255) 50%,
rgb(234, 243, 255));
On 2014/02/05 14:39:00, eustas wrote:
> The value is invalid. 'linear' parameter should have been removed!

Excellent catch! Followed up with https://codereview.chromium.org/152033007/

Thanks!

Powered by Google App Engine
This is Rietveld 408576698