Account for total glyph overflow in CachingWordShaper::width

Account for total glyph overflow in CachingWordShaper::width

CachingWordShaper::width works by splitting text runs along word
boundaries and incrementing the width & glyph bounding box of each
word separately. The function had a bug where the glyph bounding box
of all words was effectively at the origin. This patch translates the
glyph bounding box into the space of the current word before unioning.

This patch fixes the repaint bugs seen in http://jsbin.com/mimujepiki
but only a unit test has been added to prove correctness.

BUG=569833, 566285
Committed: https://crrev.com/7d40658c384377727dff93c196d79a5f70df9a11
Cr-Commit-Position: refs/heads/master@{#365612}

[pdr., 2015-12-15 07:57:26]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[pdr., 2015-12-15 07:57:43]

pdr@chromium.org changed reviewers:
+ drott@chromium.org, eae@chromium.org

[commit-bot: I haz the power, 2015-12-15 07:57:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1524913003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1524913003/1

[pdr., 2015-12-15 08:40:11]

It looks like this may need a few rebaselines but this is otherwise ready for
review.

[commit-bot: I haz the power, 2015-12-15 09:15:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-15 09:15:52]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[pdr., 2015-12-15 19:17:16]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-15 19:18:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1524913003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1524913003/20001

[pdr., 2015-12-15 19:38:48]

pdr@chromium.org changed reviewers:
+ leviw@chromium.org

[pdr., 2015-12-15 21:15:38]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-15 21:18:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1524913003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1524913003/40001

[commit-bot: I haz the power, 2015-12-15 23:07:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-15 23:07:12]

Dry run: This issue passed the CQ dry run.

[pdr., 2015-12-16 02:45:41]

Description was changed from

==========
Account for total glyph overflow in CachingWordShaper::width

CachingWordShaper::width works by splitting text runs along word
boundaries and incrementing the width & glyph bounding box of each
word separately. The function had a bug where the glyph bounding box
of all words was effectively at the origin. This patch translates the
glyph bounding box into the space of the current word before unioning.

This patch fixes the repaint bugs seen in http://jsbin.com/mimujepiki
but only a unit test has been added to prove correctness.

BUG=569833
==========

to

==========
Account for total glyph overflow in CachingWordShaper::width

CachingWordShaper::width works by splitting text runs along word
boundaries and incrementing the width & glyph bounding box of each
word separately. The function had a bug where the glyph bounding box
of all words was effectively at the origin. This patch translates the
glyph bounding box into the space of the current word before unioning.

This patch fixes the repaint bugs seen in http://jsbin.com/mimujepiki
but only a unit test has been added to prove correctness.

BUG=569833,566285
==========

[drott, 2015-12-16 08:35:49]

LGTM, nice, well spotted!

[pdr., 2015-12-16 17:27:20]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2015-12-16 17:28:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1524913003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1524913003/40001

[commit-bot: I haz the power, 2015-12-16 17:34:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 17:34:55]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pdr., 2015-12-16 18:54:25]

The CQ bit was checked by pdr@chromium.org

[pdr., 2015-12-16 18:54:26]

The patchset sent to the CQ was uploaded after l-g-t-m from drott@chromium.org
Link to the patchset: https://codereview.chromium.org/1524913003/#ps60001
(title: "Ace of rebase")

[commit-bot: I haz the power, 2015-12-16 18:56:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1524913003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1524913003/60001

[commit-bot: I haz the power, 2015-12-16 20:51:26]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-16 20:53:07]

Description was changed from

==========
Account for total glyph overflow in CachingWordShaper::width

CachingWordShaper::width works by splitting text runs along word
boundaries and incrementing the width & glyph bounding box of each
word separately. The function had a bug where the glyph bounding box
of all words was effectively at the origin. This patch translates the
glyph bounding box into the space of the current word before unioning.

This patch fixes the repaint bugs seen in http://jsbin.com/mimujepiki
but only a unit test has been added to prove correctness.

BUG=569833,566285
==========

to

==========
Account for total glyph overflow in CachingWordShaper::width

CachingWordShaper::width works by splitting text runs along word
boundaries and incrementing the width & glyph bounding box of each
word separately. The function had a bug where the glyph bounding box
of all words was effectively at the origin. This patch translates the
glyph bounding box into the space of the current word before unioning.

This patch fixes the repaint bugs seen in http://jsbin.com/mimujepiki
but only a unit test has been added to prove correctness.

BUG=569833,566285

Committed: https://crrev.com/7d40658c384377727dff93c196d79a5f70df9a11
Cr-Commit-Position: refs/heads/master@{#365612}
==========

[commit-bot: I haz the power, 2015-12-16 20:53:08]

Patchset 4 (id:??) landed as
https://crrev.com/7d40658c384377727dff93c196d79a5f70df9a11
Cr-Commit-Position: refs/heads/master@{#365612}