[Interpreter] Add support for break statements in labelled blocks.

[Interpreter] Add support for break statements in labelled blocks.

BUG=V8:4280
LOG=N

Committed: https://crrev.com/d0304f91eeec8d176303464a8d9d75d5cf1445e3
Cr-Commit-Position: refs/heads/master@{#32912}

[oth, 2015-12-14 21:59:58]

The CQ bit was checked by oth@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-14 22:00:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1524893003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1524893003/1

[oth, 2015-12-14 22:08:42]

oth@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[oth, 2015-12-14 22:08:42]

Ross, PTAL. This fixes the test262 failure that depends on break statements in
labelled blocks. Thanks!

[rmcilroy, 2015-12-16 13:07:25]

LGTM, thanks!

https://codereview.chromium.org/1524893003/diff/40001/src/interpreter/bytecod...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/1524893003/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecode-generator.cc:505: if (stmt->labels() != nullptr)
block_builder.EndBlock();
optional - can we remove the conditional here?

[oth, 2015-12-16 16:37:42]

On 2015/12/16 13:07:25, rmcilroy wrote:
> LGTM, thanks!
> 
>
https://codereview.chromium.org/1524893003/diff/40001/src/interpreter/bytecod...
> File src/interpreter/bytecode-generator.cc (right):
> 
>
https://codereview.chromium.org/1524893003/diff/40001/src/interpreter/bytecod...
> src/interpreter/bytecode-generator.cc:505: if (stmt->labels() != nullptr)
> block_builder.EndBlock();
> optional - can we remove the conditional here?

This could be removed as the parser will complain about a syntax error if
there's a break in an unlabelled block. Leaving for parity with other ast
consumers.

[oth, 2015-12-16 16:47:07]

The CQ bit was checked by oth@chromium.org

[oth, 2015-12-16 16:47:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1524893003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2015-12-16 16:47:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1524893003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1524893003/60001

[commit-bot: I haz the power, 2015-12-16 17:06:09]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-16 17:06:37]

Description was changed from

==========
[Interpreter] Add support for break statements in labelled blocks.

BUG=V8:4280
LOG=N
==========

to

==========
[Interpreter] Add support for break statements in labelled blocks.

BUG=V8:4280
LOG=N

Committed: https://crrev.com/d0304f91eeec8d176303464a8d9d75d5cf1445e3
Cr-Commit-Position: refs/heads/master@{#32912}
==========

[commit-bot: I haz the power, 2015-12-16 17:06:38]

Patchset 4 (id:??) landed as
https://crrev.com/d0304f91eeec8d176303464a8d9d75d5cf1445e3
Cr-Commit-Position: refs/heads/master@{#32912}