Creates a BattOrConnection for communicating with the BattOr

tools/battor_agent/battor_agent_bin.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file provides a thin binary wrapper around the BattOr Agent
 // library. This binary wrapper provides a means for non-C++ tracing
 // controllers, such as Telemetry and Android Systrace, to issue high-level
 // tracing commands to the BattOr..
 
 #include <iostream>
@@ skipping 31 matching lines @@
 
 void PrintSupportsExplicitClockSync() {
   std::cout << battor::BattOrAgent::SupportsExplicitClockSync() << endl;
 }
 
 // Retrieves argument argnum from the argument list, printing the usage
 // guidelines and exiting with an error code if the argument doesn't exist.
 std::string GetArg(int argnum, int argc, char* argv[]) {
   if (argnum >= argc) {
     PrintUsage();
-    PLOG(FATAL);
+    exit(1);
   }
 
   return argv[argnum];
 }
 
 // Checks if an error occurred and, if it did, prints the error and exits
 // with an error code.
 void CheckError(battor::BattOrError error) {
-  if (error != battor::BATTOR_ERROR_NONE) {
-    LOG(ERROR) << "Fatal error when communicating with the BattOr: " << error;
-    PLOG(FATAL);

[Primiano Tucci (use gerrit), 2015/12/15 11:07:19]

out of cusiosity why are you removing the P here?

[charliea (OOO until 10-5), 2015/12/15 23:50:04]

PLOG just appends the last system error to whatever message I specify. In our
case, a system error wasn't the reason for exiting the program, and may have
been completely unrelated to our program running.

For example, when I did:

  $ cd /this/directory/doesnt/exist

bash: cd: /this/directory/doesnt/exist: No such file or directory

and then:
  $ out/Default/battor_agent StartTracing /dev/nonexistent

I got:
Fatal error when communicating with the BattOr:
cd: /this/directory/doesnt/exist: No such file or directory

Given that we weren't necessarily exiting due to a system error, I think
LOG(FATAL) is probably the way to go

-  }
+  if (error != battor::BATTOR_ERROR_NONE)
+    LOG(FATAL) << "Fatal error when communicating with the BattOr: " << error;
 }
 
 // Prints an error message and exits due to a required thread failing to start.
 void ExitFromThreadStartFailure(const std::string& thread_name) {
-  LOG(ERROR) << "Failed to start " << thread_name;
-  PLOG(FATAL);
+  LOG(FATAL) << "Failed to start " << thread_name;
 }
 
 }  // namespace
 
 namespace battor {
 
 // Wrapper class containing all state necessary for an independent binary to
 // use a BattOrAgent to communicate with a BattOr.
 class BattOrAgentBin : public BattOrAgent::Listener {
  public:
   BattOrAgentBin()
       : done_(false, false),
         io_thread_(kIoThreadName),
         file_thread_(kFileThreadName),
         ui_thread_(kUiThreadName) {}
 
-  ~BattOrAgentBin() {
-    DCHECK(!agent_);
-  }
+  ~BattOrAgentBin() { DCHECK(!agent_); }
 
   // Runs the BattOr binary and returns the exit code.
   int Run(int argc, char* argv[]) {
     std::string cmd = GetArg(1, argc, argv);
 
     // SupportsExplicitClockSync doesn't need to use the serial connection, so
     // handle it separately.
     if (cmd == "SupportsExplicitClockSync") {
       PrintSupportsExplicitClockSync();
       return 0;
@@ skipping 111 matching lines @@
   scoped_ptr<BattOrAgent> agent_;
 };
 
 }  // namespace battor
 
 int main(int argc, char* argv[]) {
   base::AtExitManager exit_manager;
   battor::BattOrAgentBin bin;
   return bin.Run(argc, argv);
 }