Don't use a delgating constructor passing a member variable.

base/metrics/histogram_samples.cc

Index: base/metrics/histogram_samples.cc
diff --git a/base/metrics/histogram_samples.cc b/base/metrics/histogram_samples.cc
index b6303a53b469cbdbb9602fa3009cefc230e121c5..4cd8e556b81c556dff9c2050348c47449c2d06c9 100644
--- a/base/metrics/histogram_samples.cc
+++ b/base/metrics/histogram_samples.cc
@@ -59,8 +59,16 @@ void SampleCountPickleIterator::Get(HistogramBase::Sample* min,
 
 }  // namespace
 
+// Don't try to delegate behavior to the constructor below that accepts a
+// Matadata pointer by passing &local_meta_. Such cannot be reliably passed

[Nico, 2015/12/14 20:49:01]

typo matadata

+// because it has not yet been constructed -- no member variables have; the
+// class itself is in the middle of being constructed. Using it to
+// initialize meta_ is okay because the object now exists and local_meta_
+// is before meta_ in the construction order.
 HistogramSamples::HistogramSamples(uint64_t id)
-    : HistogramSamples(id, &local_meta_) {}
+    : meta_(&local_meta_) {
+  meta_->id = id;
+}
 
 HistogramSamples::HistogramSamples(uint64_t id, Metadata* meta)
     : meta_(meta) {