Don't use a delgating constructor passing a member variable.

Don't use a delgating constructor passing a member variable.

Don't try to delegate behavior to the constructor below that accepts a
Matadata pointer by passing &local_meta_. Such cannot be reliably passed
because it has not yet been constructed -- no member variables have; the
class itself is in the middle of being constructed.

BUG=569187
Committed: https://crrev.com/0fa944d5a0fa7e0d722b735b0866dc652c9134c1
Cr-Commit-Position: refs/heads/master@{#365084}

[bcwhite, 2015-12-14 18:38:09]

bcwhite@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2015-12-14 18:54:42]

lgtm, please expand the CL description to have the same info as you put in the
comment. Thanks!

https://codereview.chromium.org/1524853002/diff/1/base/metrics/histogram_samp...
File base/metrics/histogram_samples.cc (right):

https://codereview.chromium.org/1524853002/diff/1/base/metrics/histogram_samp...
base/metrics/histogram_samples.cc:75: DCHECK(meta_->id == 0 || meta_->id == id);
Nit: Add this line to the ctor above.

[bcwhite, 2015-12-14 19:09:07]

Description was changed from

==========
Don't use a delgating constructor passing a member variable.

BUG=569187
==========

to

==========
Don't use a delgating constructor passing a member variable.

Don't try to delegate behavior to the constructor below that accepts a
Matadata pointer by passing &local_meta_. Such cannot be reliably passed
because it has not yet been constructed -- no member variables have; the
class itself is in the middle of being constructed.


BUG=569187
==========

[bcwhite, 2015-12-14 19:11:08]

CL description expanded.

https://codereview.chromium.org/1524853002/diff/1/base/metrics/histogram_samp...
File base/metrics/histogram_samples.cc (right):

https://codereview.chromium.org/1524853002/diff/1/base/metrics/histogram_samp...
base/metrics/histogram_samples.cc:75: DCHECK(meta_->id == 0 || meta_->id == id);
On 2015/12/14 18:54:41, Alexei Svitkine (slow) wrote:
> Nit: Add this line to the ctor above.

Unnecessary since local_meta_ has just been constructed and is guaranteed to
have an default id of zero.

[bcwhite, 2015-12-14 20:17:38]

The CQ bit was checked by bcwhite@chromium.org

[commit-bot: I haz the power, 2015-12-14 20:20:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1524853002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1524853002/1

[commit-bot: I haz the power, 2015-12-14 20:26:04]

Description was changed from

==========
Don't use a delgating constructor passing a member variable.

Don't try to delegate behavior to the constructor below that accepts a
Matadata pointer by passing &local_meta_. Such cannot be reliably passed
because it has not yet been constructed -- no member variables have; the
class itself is in the middle of being constructed.


BUG=569187
==========

to

==========
Don't use a delgating constructor passing a member variable.

Don't try to delegate behavior to the constructor below that accepts a
Matadata pointer by passing &local_meta_. Such cannot be reliably passed
because it has not yet been constructed -- no member variables have; the
class itself is in the middle of being constructed.


BUG=569187
==========

[commit-bot: I haz the power, 2015-12-14 20:26:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-14 20:28:08]

Description was changed from

==========
Don't use a delgating constructor passing a member variable.

Don't try to delegate behavior to the constructor below that accepts a
Matadata pointer by passing &local_meta_. Such cannot be reliably passed
because it has not yet been constructed -- no member variables have; the
class itself is in the middle of being constructed.


BUG=569187
==========

to

==========
Don't use a delgating constructor passing a member variable.

Don't try to delegate behavior to the constructor below that accepts a
Matadata pointer by passing &local_meta_. Such cannot be reliably passed
because it has not yet been constructed -- no member variables have; the
class itself is in the middle of being constructed.

BUG=569187

Committed: https://crrev.com/0fa944d5a0fa7e0d722b735b0866dc652c9134c1
Cr-Commit-Position: refs/heads/master@{#365084}
==========

[commit-bot: I haz the power, 2015-12-14 20:28:08]

Patchset 1 (id:??) landed as
https://crrev.com/0fa944d5a0fa7e0d722b735b0866dc652c9134c1
Cr-Commit-Position: refs/heads/master@{#365084}

[Nico, 2015-12-14 20:49:01]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-12-14 20:49:01]

https://codereview.chromium.org/1524853002/diff/1/base/metrics/histogram_samp...
File base/metrics/histogram_samples.cc (right):

https://codereview.chromium.org/1524853002/diff/1/base/metrics/histogram_samp...
base/metrics/histogram_samples.cc:63: // Matadata pointer by passing
&local_meta_. Such cannot be reliably passed
typo matadata