JS: Format if statements with no else on a single line

JS: Format if statements with no else on a single line

To match Dart style:
https://www.dartlang.org/effective-dart/style/#do-use-curly-braces-for-all-flow-control-structures

(also, that's the style we use in our .js runtime files, so that will help with diffs of the js->dart runtime migration from https://github.com/dart-lang/dev_compiler/issues/310)

BUG=
R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/1c1ab7de00a787f8a108ba4330a5fd2242036747

[ochafik, 2015-12-14 18:03:34]

Description was changed from

==========
JS: Format if statements with no else on a single line

To match Dart style:
https://www.dartlang.org/effective-dart/style/#do-use-curly-braces-for-a
ll-flow-control-structures

BUG=
==========

to

==========
JS: Format if statements with no else on a single line

To match Dart style:
https://www.dartlang.org/effective-dart/style/#do-use-curly-braces-for-a
ll-flow-control-structures

(also, that's the style we use in our .js runtime files, so that will help with
diffs of the js->dart runtime migration from
https://github.com/dart-lang/dev_compiler/issues/310)

BUG=
==========

[ochafik, 2015-12-14 18:04:01]

ochafik@google.com changed reviewers:
+ jmesserly@google.com, vsm@google.com

[ochafik, 2015-12-14 18:05:04]

Description was changed from

==========
JS: Format if statements with no else on a single line

To match Dart style:
https://www.dartlang.org/effective-dart/style/#do-use-curly-braces-for-a
ll-flow-control-structures

(also, that's the style we use in our .js runtime files, so that will help with
diffs of the js->dart runtime migration from
https://github.com/dart-lang/dev_compiler/issues/310)

BUG=
==========

to

==========
JS: Format if statements with no else on a single line

To match Dart style:
https://www.dartlang.org/effective-dart/style/#do-use-curly-braces-for-all-fl...

(also, that's the style we use in our .js runtime files, so that will help with
diffs of the js->dart runtime migration from
https://github.com/dart-lang/dev_compiler/issues/310)

BUG=
==========

[Jennifer Messerly, 2015-12-15 23:57:10]

https://codereview.chromium.org/1524843002/diff/20001/lib/src/js/printer.dart
File lib/src/js/printer.dart (right):

https://codereview.chromium.org/1524843002/diff/20001/lib/src/js/printer.dart...
lib/src/js/printer.dart:185: bool _skipNextIndent = false;
style nit: it looks like they're keeping all fields up top.

https://codereview.chromium.org/1524843002/diff/20001/lib/src/js/printer.dart...
lib/src/js/printer.dart:311: bool thenWasBlock;
nice readability improvement.

Would it be possible to put this under a flag?

See JavaScriptPrintingOptions at the top of the file.

We can set this flag always in DDC. But this allows us to upstream the changes
to dart2js.

https://codereview.chromium.org/1524843002/diff/20001/lib/src/js/printer.dart...
lib/src/js/printer.dart:314: if (!shouldCompressOutput) spaceOut();
spaceOut() already does the shouldCompressOutput, so this can just be:

    spaceOut();

https://codereview.chromium.org/1524843002/diff/20001/lib/src/js/printer.dart...
lib/src/js/printer.dart:318: thenWasBlock = blockBody(then, needsSeparation:
false, needsNewline: !hasElse);
long line

[ochafik, 2015-12-16 02:00:37]

Thanks John!

https://codereview.chromium.org/1524843002/diff/20001/lib/src/js/printer.dart
File lib/src/js/printer.dart (right):

https://codereview.chromium.org/1524843002/diff/20001/lib/src/js/printer.dart...
lib/src/js/printer.dart:185: bool _skipNextIndent = false;
On 2015/12/15 23:57:10, John Messerly wrote:
> style nit: it looks like they're keeping all fields up top.

Done.

https://codereview.chromium.org/1524843002/diff/20001/lib/src/js/printer.dart...
lib/src/js/printer.dart:311: bool thenWasBlock;
On 2015/12/15 23:57:10, John Messerly wrote:
> nice readability improvement.
> 
> Would it be possible to put this under a flag?
> 
> See JavaScriptPrintingOptions at the top of the file.
> 
> We can set this flag always in DDC. But this allows us to upstream the changes
> to dart2js.

Done (didn't realize the contamination potential :-))

https://codereview.chromium.org/1524843002/diff/20001/lib/src/js/printer.dart...
lib/src/js/printer.dart:314: if (!shouldCompressOutput) spaceOut();
On 2015/12/15 23:57:10, John Messerly wrote:
> spaceOut() already does the shouldCompressOutput, so this can just be:
> 
>     spaceOut();

D'oh!

https://codereview.chromium.org/1524843002/diff/20001/lib/src/js/printer.dart...
lib/src/js/printer.dart:318: thenWasBlock = blockBody(then, needsSeparation:
false, needsNewline: !hasElse);
On 2015/12/15 23:57:10, John Messerly wrote:
> long line

Done.

[Jennifer Messerly, 2015-12-16 18:54:14]

lgtm!

[ochafik, 2015-12-16 19:45:24]

Description was changed from

==========
JS: Format if statements with no else on a single line

To match Dart style:
https://www.dartlang.org/effective-dart/style/#do-use-curly-braces-for-all-fl...

(also, that's the style we use in our .js runtime files, so that will help with
diffs of the js->dart runtime migration from
https://github.com/dart-lang/dev_compiler/issues/310)

BUG=
==========

to

==========
JS: Format if statements with no else on a single line

To match Dart style:
https://www.dartlang.org/effective-dart/style/#do-use-curly-braces-for-all-fl...

(also, that's the style we use in our .js runtime files, so that will help with
diffs of the js->dart runtime migration from
https://github.com/dart-lang/dev_compiler/issues/310)

BUG=
R=jmesserly@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/1c1ab7de00a787f8a108ba4330a5...
==========

[ochafik, 2015-12-16 19:45:25]

Committed patchset #5 (id:70001) manually as
1c1ab7de00a787f8a108ba4330a5fd2242036747 (presubmit successful).