[WebSocket] Add Cache-Control to the request header.

[WebSocket] Add Cache-Control to the request header.

In order to suppress cache on servers, added LOAD_BYPASS_CACHE to
the load flags.
Additionally, added some messages on opening handshake failure.

BUG=339373
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248971

[Adam Rice, 2014-02-03 08:43:51]

https://codereview.chromium.org/152483003/diff/90001/net/websockets/websocket...
File net/websockets/websocket_basic_handshake_stream.cc (right):

https://codereview.chromium.org/152483003/diff/90001/net/websockets/websocket...
net/websockets/websocket_basic_handshake_stream.cc:540:
OnFinishOpeningHandshake();
OnFinishOpeningHandshake() is also called at line 421, so similar logic will be
needed there. I think when HttpStreamParser returns a |result| other than OK, it
is probably more useful to log the net error code than to log the HTTP response
code.

[yhirano, 2014-02-03 09:32:52]

https://codereview.chromium.org/152483003/diff/90001/net/websockets/websocket...
File net/websockets/websocket_basic_handshake_stream.cc (right):

https://codereview.chromium.org/152483003/diff/90001/net/websockets/websocket...
net/websockets/websocket_basic_handshake_stream.cc:540:
OnFinishOpeningHandshake();
On 2014/02/03 08:43:52, Adam Rice wrote:
> OnFinishOpeningHandshake() is also called at line 421, so similar logic will
be
> needed there. I think when HttpStreamParser returns a |result| other than OK,
it
> is probably more useful to log the net error code than to log the HTTP
response
> code.
Done in ValidateResponse.

HttpStreamParser returns an error when it detects 404.
I think "Unexpected status code: 404" is more useful then "net::ERR_FAILED" in
such case.

[Adam Rice, 2014-02-04 03:52:46]

https://codereview.chromium.org/152483003/diff/90001/net/websockets/websocket...
File net/websockets/websocket_basic_handshake_stream.cc (right):

https://codereview.chromium.org/152483003/diff/90001/net/websockets/websocket...
net/websockets/websocket_basic_handshake_stream.cc:540:
OnFinishOpeningHandshake();
On 2014/02/03 09:32:52, yhirano wrote:
> On 2014/02/03 08:43:52, Adam Rice wrote:
> > OnFinishOpeningHandshake() is also called at line 421, so similar logic will
> be
> > needed there. I think when HttpStreamParser returns a |result| other than
OK,
> it
> > is probably more useful to log the net error code than to log the HTTP
> response
> > code.
> Done in ValidateResponse.
> 
> HttpStreamParser returns an error when it detects 404.
> I think "Unexpected status code: 404" is more useful then "net::ERR_FAILED" in
> such case.

In my tests, HttpStreamParser returns a positive value on 404. I have filed a
bug http://crbug.com/340533 to try to get more information. In the meantime, I
think we will have to change if (result == OK) to if (result >= 0). Do you want
to do that in this CL?

https://codereview.chromium.org/152483003/diff/190001/net/websockets/websocke...
File net/websockets/websocket_basic_handshake_stream.h (right):

https://codereview.chromium.org/152483003/diff/190001/net/websockets/websocke...
net/websockets/websocket_basic_handshake_stream.h:89: // Validates the response
and notifies the finished handshake information.
This sounds a little strange. How about "and sends the finished handshake
event"?

[yhirano, 2014-02-04 04:15:50]

https://codereview.chromium.org/152483003/diff/90001/net/websockets/websocket...
File net/websockets/websocket_basic_handshake_stream.cc (right):

https://codereview.chromium.org/152483003/diff/90001/net/websockets/websocket...
net/websockets/websocket_basic_handshake_stream.cc:540:
OnFinishOpeningHandshake();
On 2014/02/04 03:52:46, Adam Rice wrote:
> On 2014/02/03 09:32:52, yhirano wrote:
> > On 2014/02/03 08:43:52, Adam Rice wrote:
> > > OnFinishOpeningHandshake() is also called at line 421, so similar logic
will
> > be
> > > needed there. I think when HttpStreamParser returns a |result| other than
> OK,
> > it
> > > is probably more useful to log the net error code than to log the HTTP
> > response
> > > code.
> > Done in ValidateResponse.
> > 
> > HttpStreamParser returns an error when it detects 404.
> > I think "Unexpected status code: 404" is more useful then "net::ERR_FAILED"
in
> > such case.
> 
> In my tests, HttpStreamParser returns a positive value on 404. I have filed a
> bug http://crbug.com/340533 to try to get more information. In the meantime, I
> think we will have to change if (result == OK) to if (result >= 0). Do you
want
> to do that in this CL?

Done.

https://codereview.chromium.org/152483003/diff/190001/net/websockets/websocke...
File net/websockets/websocket_basic_handshake_stream.h (right):

https://codereview.chromium.org/152483003/diff/190001/net/websockets/websocke...
net/websockets/websocket_basic_handshake_stream.h:89: // Validates the response
and notifies the finished handshake information.
On 2014/02/04 03:52:46, Adam Rice wrote:
> This sounds a little strange. How about "and sends the finished handshake
> event"?

Done.

[Adam Rice, 2014-02-04 04:19:21]

lgtm

[yhirano, 2014-02-04 04:20:03]

+tyoshino for OWNER review

[tyoshino (SeeGerritForStatus), 2014-02-04 05:33:52]

https://codereview.chromium.org/152483003/diff/310001/net/websockets/websocke...
File net/websockets/websocket_basic_handshake_stream.cc (right):

https://codereview.chromium.org/152483003/diff/310001/net/websockets/websocke...
net/websockets/websocket_basic_handshake_stream.cc:551: // We need to pass these
through for authentication to work.
keep this aligned with l552

https://codereview.chromium.org/152483003/diff/310001/net/websockets/websocke...
net/websockets/websocket_basic_handshake_stream.cc:557: // WHATWG WebSocket API
spec) and so are dropped by default.
ditto

https://codereview.chromium.org/152483003/diff/310001/net/websockets/websocke...
net/websockets/websocket_basic_handshake_stream.cc:568:
ErrorToString(MapSystemError(rv));
rv is net error. you don't need MapSystemError call, I think

[yhirano, 2014-02-04 05:37:39]

https://codereview.chromium.org/152483003/diff/310001/net/websockets/websocke...
File net/websockets/websocket_basic_handshake_stream.cc (right):

https://codereview.chromium.org/152483003/diff/310001/net/websockets/websocke...
net/websockets/websocket_basic_handshake_stream.cc:551: // We need to pass these
through for authentication to work.
On 2014/02/04 05:33:52, tyoshino wrote:
> keep this aligned with l552

Done.

https://codereview.chromium.org/152483003/diff/310001/net/websockets/websocke...
net/websockets/websocket_basic_handshake_stream.cc:557: // WHATWG WebSocket API
spec) and so are dropped by default.
On 2014/02/04 05:33:52, tyoshino wrote:
> ditto

Done.

https://codereview.chromium.org/152483003/diff/310001/net/websockets/websocke...
net/websockets/websocket_basic_handshake_stream.cc:568:
ErrorToString(MapSystemError(rv));
On 2014/02/04 05:33:52, tyoshino wrote:
> rv is net error. you don't need MapSystemError call, I think

Done.

[tyoshino (SeeGerritForStatus), 2014-02-05 07:52:22]

lgtm

[yhirano, 2014-02-05 07:53:39]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2014-02-05 08:05:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yhirano@chromium.org/152483003/420001

[commit-bot: I haz the power, 2014-02-05 09:42:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-05 09:42:08]

Retried try job too often on android_aosp for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_ao...

[yhirano, 2014-02-05 10:06:33]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2014-02-05 10:08:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yhirano@chromium.org/152483003/420001

[commit-bot: I haz the power, 2014-02-05 11:19:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-05 11:19:41]

Retried try job too often on android_aosp for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_ao...

[yhirano, 2014-02-05 11:51:20]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2014-02-05 11:54:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yhirano@chromium.org/152483003/420001

[commit-bot: I haz the power, 2014-02-05 12:28:52]

Change committed as 248971