src/interpreter/bytecodes.h - Issue 1524803003: [Interpreter] Add support for Load / Store to Lookup slots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecodes.h

Issue 1524803003: [Interpreter] Add support for Load / Store to Lookup slots. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@init_eval_impl

Patch Set: rebased the patch and fixed tests. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/interpreter/bytecodes.h

diff --git a/src/interpreter/bytecodes.h b/src/interpreter/bytecodes.h

index f55a4af731eda9770254f0b95d52ce3d1e5d17f5..d6b8562d6127c1086809202f20ee37625646a190 100644

--- a/src/interpreter/bytecodes.h

+++ b/src/interpreter/bytecodes.h

@@ -66,6 +66,12 @@ namespace interpreter {

V(LdaContextSlot, OperandType::kReg8, OperandType::kIdx8) \

V(StaContextSlot, OperandType::kReg8, OperandType::kIdx8) \

+ /* Load-Store LookupSlots */ \

rmcilroy 2015/12/15 16:44:32 /s/LookupSlots/lookup slots/

mythria 2015/12/16 09:54:21 Done.

+ V(LdaLookupSlot, OperandType::kIdx8) \

+ V(LdaLookupSlotInsideTypeof, OperandType::kIdx8) \

+ V(StaLookupSlotSloppy, OperandType::kIdx8) \

+ V(StaLookupSlotStrict, OperandType::kIdx8) \

+ \

/* Register-accumulator transfers */ \

V(Ldar, OperandType::kReg8) \

V(Star, OperandType::kReg8) \

« src/interpreter/bytecode-array-builder.cc ('K') | « src/interpreter/bytecode-generator.cc ('k') | src/interpreter/interpreter.cc » ('j') | src/interpreter/interpreter.cc » ('J')