Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1524673002: [fullcodegen] Add support for %_GetSuperConstructor. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcodegen] Add support for %_GetSuperConstructor. Since the parser now desugars super constructor calls to simple primitives, we can also easily optimize those in fullcodegen w/ just a few simple lines of native code per architecture. This code in particular should be fast, so it seems worth the code in fullcodegen. BUG=v8:3330 LOG=n Committed: https://crrev.com/812bcd4494b5f2152274001c045968a779ea7c21 Cr-Commit-Position: refs/heads/master@{#32823}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -0 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Benedikt Meurer
Hey Yang, Simple change. Please take a look. Thanks, Benedikt
5 years ago (2015-12-14 05:51:35 UTC) #2
Yang
On 2015/12/14 05:51:35, Benedikt Meurer wrote: > Hey Yang, > > Simple change. > Please ...
5 years ago (2015-12-14 05:53:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1524673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1524673002/1
5 years ago (2015-12-14 05:54:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-14 05:56:03 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-14 05:56:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/812bcd4494b5f2152274001c045968a779ea7c21
Cr-Commit-Position: refs/heads/master@{#32823}

Powered by Google App Engine
This is Rietveld 408576698