Issue 1524573002: Remove //skia/skia_gn_files.gypi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1524573002: Remove //skia/skia_gn_files.gypi. (Closed)

Created:
5 years ago by viettrungluu

Modified:
5 years ago

Reviewers:
kulakowski1

CC:
mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove //skia/skia_gn_files.gypi. There's an "argument" for using the gypi files from upstream skia (in //third_party/skia), but this one is totally unnecessary. R=kulakowski@google.com Committed: https://chromium.googlesource.com/external/mojo/+/af1033ffe0a58e8eb037178c4c77cdfb1a8da62f

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -77 lines)			Patch
	M	skia/BUILD.gn	View	1	4 chunks	+39 lines, -23 lines	0 comments	Download
	D	skia/skia_gn_files.gypi	View		1 chunk	+0 lines, -54 lines	0 comments	Download

Total messages: 4 (1 generated)

kulakowski1

I'm sure you have excellent "rebuttals" to such an "argument". lgtm

5 years ago (2015-12-12 01:00:08 UTC) #2

viettrungluu

5 years ago (2015-12-12 01:07:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
af1033ffe0a58e8eb037178c4c77cdfb1a8da62f (presubmit successful).