Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1524493002: Revert "Make `analyzer_cli` tests bot-friendly (#25001)." (Closed)

Created:
5 years ago by pquitslund
Modified:
5 years ago
Reviewers:
Paul Berry, keertip
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Make `analyzer_cli` tests bot-friendly (#25001)." This reverts commit e67affe6b6e35f7ed933c1736b60dc10bf164652. R=keertip@google.com Committed: https://github.com/dart-lang/sdk/commit/1c3df7f4ecb7b4a503fa9aa4e88d584c436006f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -62 lines) Patch
M pkg/analyzer_cli/test/all.dart View 1 chunk +8 lines, -6 lines 0 comments Download
M pkg/analyzer_cli/test/driver_test.dart View 11 chunks +78 lines, -53 lines 0 comments Download
M pkg/analyzer_cli/test/sdk_ext_test.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer_cli/test/strong_mode_test.dart View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
pquitslund
Mysterious failures on the bots (not reproduced locally). Reverting pending further investigation. ``` Command[vm]: DART_CONFIGURATION=DebugIA32 ...
5 years ago (2015-12-11 22:54:15 UTC) #2
pquitslund
5 years ago (2015-12-11 22:54:58 UTC) #4
keertip
lgtm
5 years ago (2015-12-11 22:55:41 UTC) #5
pquitslund
5 years ago (2015-12-11 22:57:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1c3df7f4ecb7b4a503fa9aa4e88d584c436006f0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698