Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1524473002: Remove fontconfig. (Closed)

Created:
5 years ago by viettrungluu
Modified:
5 years ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -7212 lines) Patch
M build/config/BUILD.gn View 3 chunks +2 lines, -10 lines 0 comments Download
M build/config/fnl/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M build/config/linux/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M skia/BUILD.gn View 4 chunks +15 lines, -12 lines 0 comments Download
A skia/ports/font_mgr_factory.cc View 1 chunk +32 lines, -0 lines 1 comment Download
D third_party/fontconfig/BUILD.gn View 1 chunk +0 lines, -71 lines 0 comments Download
D third_party/fontconfig/LICENSE View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/fontconfig/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/fontconfig/README.chromium View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/fontconfig/chromium/empty.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/fontconfig/include/config.h View 1 chunk +0 lines, -360 lines 0 comments Download
D third_party/fontconfig/include/fc-case/fcalias.h View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/fontconfig/include/fc-case/fcaliastail.h View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/fontconfig/include/fc-case/fccase.h View 1 chunk +0 lines, -330 lines 0 comments Download
D third_party/fontconfig/include/fc-glyphname/fcalias.h View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/fontconfig/include/fc-glyphname/fcaliastail.h View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/fontconfig/include/fc-glyphname/fcglyphname.h View 1 chunk +0 lines, -781 lines 0 comments Download
D third_party/fontconfig/include/fc-lang/fcalias.h View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/fontconfig/include/fc-lang/fcaliastail.h View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/fontconfig/include/fc-lang/fclang.h View 1 chunk +0 lines, -4176 lines 0 comments Download
D third_party/fontconfig/include/src/fcalias.h View 1 chunk +0 lines, -390 lines 0 comments Download
D third_party/fontconfig/include/src/fcaliastail.h View 1 chunk +0 lines, -440 lines 0 comments Download
D third_party/fontconfig/include/src/fcftalias.h View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/fontconfig/include/src/fcftaliastail.h View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/fontconfig/include/src/fcobjshash.h View 1 chunk +0 lines, -317 lines 0 comments Download
D third_party/fontconfig/include/src/fcstdint.h View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/base/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gfx/BUILD.gn View 3 chunks +0 lines, -11 lines 0 comments Download
D ui/gfx/test/fontconfig_util_linux.h View 1 chunk +0 lines, -63 lines 0 comments Download
D ui/gfx/test/fontconfig_util_linux.cc View 1 chunk +0 lines, -155 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
5 years ago (2015-12-11 22:19:38 UTC) #1
jamesr
lgtm https://codereview.chromium.org/1524473002/diff/1/skia/ports/font_mgr_factory.cc File skia/ports/font_mgr_factory.cc (right): https://codereview.chromium.org/1524473002/diff/1/skia/ports/font_mgr_factory.cc#newcode23 skia/ports/font_mgr_factory.cc:23: }; holy shit
5 years ago (2015-12-11 22:41:11 UTC) #2
viettrungluu
5 years ago (2015-12-11 22:46:38 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
59f4ce553bd2c1cbc87c030cbde032547ea1e58b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698