Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 1524333002: Fix race condition with multiplexed message pipes. (Closed)

Created:
5 years ago by jam
Modified:
5 years ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix race condition with multiplexed message pipes. The problem was that if a MessagePipeDispatcher was connected to a RoutedRawChannel that had buffered messages to it. OnReadMessage would be called first which would tell the awakables that it's ready for read. But if the awakable called ReadMessage before GotNonTransferableChannel was called, then they wouldn't get any messages because channel_ was null. BUG=561803 TEST=out/Debug/mojo_runner mojo:example_main --use-mus-in-renderer http://www.slashdot.org and then ctrl+n works Committed: https://crrev.com/cba3547586790f12aa2cec55f140c87f7aca0c06 Cr-Commit-Position: refs/heads/master@{#365395}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -30 lines) Patch
M mojo/edk/system/broker_state.h View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/edk/system/broker_state.cc View 4 chunks +17 lines, -15 lines 0 comments Download
M mojo/edk/system/child_broker.h View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/edk/system/child_broker.cc View 3 chunks +17 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jam
5 years ago (2015-12-15 21:38:55 UTC) #2
yzshen1
lgtm
5 years ago (2015-12-15 22:05:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1524333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1524333002/1
5 years ago (2015-12-15 23:00:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 23:44:46 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-15 23:45:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cba3547586790f12aa2cec55f140c87f7aca0c06
Cr-Commit-Position: refs/heads/master@{#365395}

Powered by Google App Engine
This is Rietveld 408576698