Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 15243002: Fix style issues in NaClDomHandlerProxy. (Closed)

Created:
7 years, 7 months ago by yael.aharon
Modified:
7 years, 7 months ago
Reviewers:
yael.aharon1, Dan Beam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix style issues in NaClDomHandlerProxy. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200738

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -43 lines) Patch
M chrome/browser/ui/webui/nacl_ui.cc View 1 8 chunks +38 lines, -43 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yael.aharon1
Address style issues from https://codereview.chromium.org/14860020/#msg28 Please review, thanks!
7 years, 7 months ago (2013-05-17 01:45:41 UTC) #1
Dan Beam
https://codereview.chromium.org/15243002/diff/1/chrome/browser/ui/webui/nacl_ui.cc File chrome/browser/ui/webui/nacl_ui.cc (right): https://codereview.chromium.org/15243002/diff/1/chrome/browser/ui/webui/nacl_ui.cc#newcode91 chrome/browser/ui/webui/nacl_ui.cc:91: virtual ~NaClDomHandlerProxy() {} move these above validatepncalpathcallback() https://codereview.chromium.org/15243002/diff/1/chrome/browser/ui/webui/nacl_ui.cc#newcode94 chrome/browser/ui/webui/nacl_ui.cc:94: ...
7 years, 7 months ago (2013-05-17 02:05:49 UTC) #2
yael.aharon1
Updated the patch per your comments. thanks https://codereview.chromium.org/15243002/diff/1/chrome/browser/ui/webui/nacl_ui.cc File chrome/browser/ui/webui/nacl_ui.cc (right): https://codereview.chromium.org/15243002/diff/1/chrome/browser/ui/webui/nacl_ui.cc#newcode91 chrome/browser/ui/webui/nacl_ui.cc:91: virtual ~NaClDomHandlerProxy() ...
7 years, 7 months ago (2013-05-17 02:20:06 UTC) #3
Dan Beam
lgtm thanks for the follow up cl! :)
7 years, 7 months ago (2013-05-17 02:25:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yael.aharon@intel.com/15243002/5001
7 years, 7 months ago (2013-05-17 02:27:28 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-17 07:01:02 UTC) #6
Message was sent while issue was closed.
Change committed as 200738

Powered by Google App Engine
This is Rietveld 408576698