Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

Issue 1524293002: [Offline pages] Expose offline pages URL related methods in java code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tab-android
Patch Set: Making the new method visible for testing Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
index cd9b8d4064b8902f466cf71c9604b90950022281..c133531248af4873e013c684cbd11d7dcbf976e8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
@@ -154,7 +154,6 @@ public final class OfflinePageBridge {
/**
* Creates offline pages bridge for a given profile.
*/
- @VisibleForTesting
public OfflinePageBridge(Profile profile) {
mNativeOfflinePageBridge = nativeInit(profile);
}
@@ -194,7 +193,6 @@ public final class OfflinePageBridge {
* Adds an observer to offline page model changes.
* @param observer The observer to be added.
*/
- @VisibleForTesting
public void addObserver(OfflinePageModelObserver observer) {
mObservers.addObserver(observer);
}
@@ -203,7 +201,6 @@ public final class OfflinePageBridge {
* Removes an observer to offline page model changes.
* @param observer The observer to be removed.
*/
- @VisibleForTesting
public void removeObserver(OfflinePageModelObserver observer) {
mObservers.removeObserver(observer);
}
@@ -211,7 +208,6 @@ public final class OfflinePageBridge {
/**
* @return Gets all available offline pages. Requires that the model is already loaded.
*/
- @VisibleForTesting
public List<OfflinePageItem> getAllPages() {
assert mIsNativeOfflinePageModelLoaded;
List<OfflinePageItem> result = new ArrayList<OfflinePageItem>();
@@ -226,7 +222,6 @@ public final class OfflinePageBridge {
* @return An {@link OfflinePageItem} matching the bookmark Id or <code>null</code> if none
* exist.
*/
- @VisibleForTesting
public OfflinePageItem getPageByBookmarkId(BookmarkId bookmarkId) {
return nativeGetPageByBookmarkId(mNativeOfflinePageBridge, bookmarkId.getId());
}
@@ -237,7 +232,6 @@ public final class OfflinePageBridge {
* @param onlineURL URL of the page.
* @return An {@link OfflinePageItem} matching the URL or <code>null</code> if none exist.
*/
- @VisibleForTesting
public OfflinePageItem getPageByOnlineURL(String onlineURL) {
return nativeGetPageByOnlineURL(mNativeOfflinePageBridge, onlineURL);
}
@@ -250,7 +244,6 @@ public final class OfflinePageBridge {
* @param callback Interface that contains a callback.
* @see SavePageCallback
*/
- @VisibleForTesting
public void savePage(final WebContents webContents, final BookmarkId bookmarkId,
final SavePageCallback callback) {
assert mIsNativeOfflinePageModelLoaded;
@@ -290,7 +283,6 @@ public final class OfflinePageBridge {
* @param callback Interface that contains a callback.
* @see DeletePageCallback
*/
- @VisibleForTesting
public void deletePage(final BookmarkId bookmarkId, DeletePageCallback callback) {
assert mIsNativeOfflinePageModelLoaded;
@@ -347,6 +339,28 @@ public final class OfflinePageBridge {
nativeCheckMetadataConsistency(mNativeOfflinePageBridge);
}
+ /**
+ * Gets the offline URL of an offline page of that is saved for the online URL.
+ * @param onlineUrl Online URL, which might have offline copy.
+ * @return URL pointing to the offline copy or <code>null</code> if none exists.
+ */
+ @VisibleForTesting
+ public String getOfflineUrlForOnlineUrl(String onlineUrl) {
+ assert mIsNativeOfflinePageModelLoaded;
+ return nativeGetOfflineUrlForOnlineUrl(mNativeOfflinePageBridge, onlineUrl);
+ }
+
+ /**
+ * Returns <code>true</code> if offline URL points to a local copy of an offline page.
+ * @param offlineUrl A URL potentially pointing to an offline copy of an offline page.
+ * @return Whether a provided url points to an offline copy of an offline page.
+ */
+ @VisibleForTesting
+ public boolean isOfflinePageUrl(String offlineUrl) {
+ assert mIsNativeOfflinePageModelLoaded;
+ return nativeIsOfflinePageUrl(mNativeOfflinePageBridge, offlineUrl);
+ }
+
private DeletePageCallback wrapCallbackWithHistogramReporting(
final DeletePageCallback callback) {
final long totalPageSizeBefore = getTotalSize(getAllPages());
@@ -425,4 +439,7 @@ public final class OfflinePageBridge {
private native void nativeGetPagesToCleanUp(
long nativeOfflinePageBridge, List<OfflinePageItem> offlinePages);
private native void nativeCheckMetadataConsistency(long nativeOfflinePageBridge);
+ private native String nativeGetOfflineUrlForOnlineUrl(
+ long nativeOfflinePageBridge, String onlineUrl);
+ private native boolean nativeIsOfflinePageUrl(long nativeOfflinePageBridge, String offlineUrl);
}

Powered by Google App Engine
This is Rietveld 408576698