Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java

Issue 1524293002: [Offline pages] Expose offline pages URL related methods in java code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tab-android
Patch Set: Setting a flag to enable offline pages in test Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
index 357a47d142508d468444c135b059784868f18f03..3ebcada26c9ebbeb67dd489b3e3e90836cc92601 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
@@ -4,10 +4,12 @@
package org.chromium.chrome.browser.offlinepages;
-import android.test.suitebuilder.annotation.MediumTest;
+import android.test.suitebuilder.annotation.SmallTest;
import org.chromium.base.ThreadUtils;
+import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.chrome.browser.ChromeActivity;
+import org.chromium.chrome.browser.ChromeSwitches;
import org.chromium.chrome.browser.offlinepages.OfflinePageBridge.DeletePageCallback;
import org.chromium.chrome.browser.offlinepages.OfflinePageBridge.OfflinePageModelObserver;
import org.chromium.chrome.browser.offlinepages.OfflinePageBridge.SavePageCallback;
@@ -27,6 +29,7 @@ import java.util.concurrent.Semaphore;
import java.util.concurrent.TimeUnit;
/** Unit tests for {@link OfflinePageBridge}. */
+@CommandLineFlags.Add({ChromeSwitches.ENABLE_OFFLINE_PAGES})
public class OfflinePageBridgeTest extends ChromeActivityTestCaseBase<ChromeActivity> {
private static final String TEST_PAGE =
TestHttpServerClient.getUrl("chrome/test/data/android/about.html");
@@ -69,13 +72,13 @@ public class OfflinePageBridgeTest extends ChromeActivityTestCaseBase<ChromeActi
startMainActivityOnBlankPage();
}
- @MediumTest
+ @SmallTest
public void testLoadOfflinePagesWhenEmpty() throws Exception {
List<OfflinePageItem> offlinePages = getAllPages();
assertEquals("Offline pages count incorrect.", 0, offlinePages.size());
}
- @MediumTest
+ @SmallTest
public void testAddOfflinePageAndLoad() throws Exception {
loadUrl(TEST_PAGE);
savePage(SavePageResult.SUCCESS, TEST_PAGE);
@@ -105,7 +108,7 @@ public class OfflinePageBridgeTest extends ChromeActivityTestCaseBase<ChromeActi
assertTrue("Offline page item size is incorrect: " + size, 600 < size && size < 800);
}
- @MediumTest
+ @SmallTest
public void testMarkPageAccessed() throws Exception {
loadUrl(TEST_PAGE);
savePage(SavePageResult.SUCCESS, TEST_PAGE);
@@ -116,7 +119,7 @@ public class OfflinePageBridgeTest extends ChromeActivityTestCaseBase<ChromeActi
markPageAccessed(BOOKMARK_ID, 1);
}
- @MediumTest
+ @SmallTest
public void testGetPageByBookmarkId() throws Exception {
loadUrl(TEST_PAGE);
savePage(SavePageResult.SUCCESS, TEST_PAGE);
@@ -135,7 +138,7 @@ public class OfflinePageBridgeTest extends ChromeActivityTestCaseBase<ChromeActi
mOfflinePageBridge.getPageByBookmarkId(new BookmarkId(-42, BookmarkType.NORMAL)));
}
- @MediumTest
+ @SmallTest
public void testDeleteOfflinePage() throws Exception {
deletePage(BOOKMARK_ID, DeletePageResult.NOT_FOUND);
loadUrl(TEST_PAGE);
@@ -147,6 +150,27 @@ public class OfflinePageBridgeTest extends ChromeActivityTestCaseBase<ChromeActi
mOfflinePageBridge.getPageByBookmarkId(BOOKMARK_ID));
}
+ @SmallTest
+ public void testGetOfflineUrlForOnlineUrl() throws Exception {
+ loadUrl(TEST_PAGE);
+ savePage(SavePageResult.SUCCESS, TEST_PAGE);
+ OfflinePageItem offlinePage = mOfflinePageBridge.getPageByBookmarkId(BOOKMARK_ID);
+ assertEquals("We should get the same offline URL, when querying using online URL",
+ offlinePage.getOfflineUrl(),
+ mOfflinePageBridge.getOfflineUrlForOnlineUrl(offlinePage.getUrl()));
+ }
+
+ @SmallTest
+ public void testIsOfflinePageUrl() throws Exception {
+ loadUrl(TEST_PAGE);
+ savePage(SavePageResult.SUCCESS, TEST_PAGE);
+ OfflinePageItem offlinePage = mOfflinePageBridge.getPageByBookmarkId(BOOKMARK_ID);
+ assertTrue("Offline URL of an offline page should clearly be an offline page URL",
+ mOfflinePageBridge.isOfflinePageUrl(offlinePage.getOfflineUrl()));
+ assertFalse("Online URL of an offline page should not be an offline page URL",
+ mOfflinePageBridge.isOfflinePageUrl(offlinePage.getUrl()));
+ }
+
private void savePage(final int expectedResult, final String expectedUrl)
throws InterruptedException {
final Semaphore semaphore = new Semaphore(0);

Powered by Google App Engine
This is Rietveld 408576698