Chromium Code Reviews| Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java |
| diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java |
| index cd9b8d4064b8902f466cf71c9604b90950022281..90933aea18713bd35ce17ec5113101cdced28c36 100644 |
| --- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java |
| +++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java |
| @@ -154,7 +154,6 @@ public final class OfflinePageBridge { |
| /** |
| * Creates offline pages bridge for a given profile. |
| */ |
| - @VisibleForTesting |
| public OfflinePageBridge(Profile profile) { |
| mNativeOfflinePageBridge = nativeInit(profile); |
| } |
| @@ -194,7 +193,6 @@ public final class OfflinePageBridge { |
| * Adds an observer to offline page model changes. |
| * @param observer The observer to be added. |
| */ |
| - @VisibleForTesting |
| public void addObserver(OfflinePageModelObserver observer) { |
| mObservers.addObserver(observer); |
| } |
| @@ -203,7 +201,6 @@ public final class OfflinePageBridge { |
| * Removes an observer to offline page model changes. |
| * @param observer The observer to be removed. |
| */ |
| - @VisibleForTesting |
| public void removeObserver(OfflinePageModelObserver observer) { |
| mObservers.removeObserver(observer); |
| } |
| @@ -211,7 +208,6 @@ public final class OfflinePageBridge { |
| /** |
| * @return Gets all available offline pages. Requires that the model is already loaded. |
| */ |
| - @VisibleForTesting |
| public List<OfflinePageItem> getAllPages() { |
| assert mIsNativeOfflinePageModelLoaded; |
| List<OfflinePageItem> result = new ArrayList<OfflinePageItem>(); |
| @@ -226,7 +222,6 @@ public final class OfflinePageBridge { |
| * @return An {@link OfflinePageItem} matching the bookmark Id or <code>null</code> if none |
| * exist. |
| */ |
| - @VisibleForTesting |
| public OfflinePageItem getPageByBookmarkId(BookmarkId bookmarkId) { |
| return nativeGetPageByBookmarkId(mNativeOfflinePageBridge, bookmarkId.getId()); |
| } |
| @@ -237,7 +232,6 @@ public final class OfflinePageBridge { |
| * @param onlineURL URL of the page. |
| * @return An {@link OfflinePageItem} matching the URL or <code>null</code> if none exist. |
| */ |
| - @VisibleForTesting |
| public OfflinePageItem getPageByOnlineURL(String onlineURL) { |
| return nativeGetPageByOnlineURL(mNativeOfflinePageBridge, onlineURL); |
| } |
| @@ -250,7 +244,6 @@ public final class OfflinePageBridge { |
| * @param callback Interface that contains a callback. |
| * @see SavePageCallback |
| */ |
| - @VisibleForTesting |
| public void savePage(final WebContents webContents, final BookmarkId bookmarkId, |
| final SavePageCallback callback) { |
| assert mIsNativeOfflinePageModelLoaded; |
| @@ -290,7 +283,6 @@ public final class OfflinePageBridge { |
| * @param callback Interface that contains a callback. |
| * @see DeletePageCallback |
| */ |
| - @VisibleForTesting |
| public void deletePage(final BookmarkId bookmarkId, DeletePageCallback callback) { |
| assert mIsNativeOfflinePageModelLoaded; |
| @@ -347,6 +339,27 @@ public final class OfflinePageBridge { |
| nativeCheckMetadataConsistency(mNativeOfflinePageBridge); |
| } |
| + /** |
| + * Gets the offline URL of based on the online url of an offline page, if one exists. |
|
jianli
2015/12/16 01:41:23
Gets the offline URL of an offline page that is sa
fgorski
2015/12/16 22:12:58
Done.
|
| + * @param onlineUrl Online URL, which might have offline copy. |
| + * @return URL pointing to the offline copy or <code>null</code> in none exists. |
|
jianli
2015/12/16 01:41:23
in => if
fgorski
2015/12/16 22:12:58
Done.
|
| + */ |
| + public String getOfflineUrlByOnlineUrl(String onlineUrl) { |
| + assert mIsNativeOfflinePageModelLoaded; |
| + return nativeGetOfflineUrlByOnlineUrl(mNativeOfflinePageBridge, onlineUrl); |
| + } |
| + |
| + /** |
| + * Checks whether a provided url belongs to an offline page. |
|
jianli
2015/12/16 01:41:23
Returns true if an offline page stored in the prov
fgorski
2015/12/16 22:12:58
Done.
|
| + * @param offlineUrl A URL potentially pointing to an offline copy of an offline page. |
| + * @return Whether a provided url points to an offline copy of an offline page. |
| + */ |
| + @VisibleForTesting |
| + public boolean isOfflinePageUrl(String offlineUrl) { |
| + assert mIsNativeOfflinePageModelLoaded; |
| + return nativeIsOfflinePageUrl(mNativeOfflinePageBridge, offlineUrl); |
| + } |
| + |
| private DeletePageCallback wrapCallbackWithHistogramReporting( |
| final DeletePageCallback callback) { |
| final long totalPageSizeBefore = getTotalSize(getAllPages()); |
| @@ -425,4 +438,7 @@ public final class OfflinePageBridge { |
| private native void nativeGetPagesToCleanUp( |
| long nativeOfflinePageBridge, List<OfflinePageItem> offlinePages); |
| private native void nativeCheckMetadataConsistency(long nativeOfflinePageBridge); |
| + private native String nativeGetOfflineUrlByOnlineUrl( |
| + long nativeOfflinePageBridge, String onlineUrl); |
| + private native boolean nativeIsOfflinePageUrl(long nativeOfflinePageBridge, String offlineUrl); |
| } |