Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Side by Side Diff: runtime/observatory/lib/src/elements/script_inset.dart

Issue 1524263002: Fix line number reporting for unresolved breakpoints. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library script_inset_element; 5 library script_inset_element;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:html'; 8 import 'dart:html';
9 import 'observatory_element.dart'; 9 import 'observatory_element.dart';
10 import 'service_ref.dart'; 10 import 'service_ref.dart';
(...skipping 411 matching lines...) Expand 10 before | Expand all | Expand 10 after
422 switch (event.kind) { 422 switch (event.kind) {
423 case ServiceEvent.kBreakpointAdded: 423 case ServiceEvent.kBreakpointAdded:
424 case ServiceEvent.kBreakpointResolved: 424 case ServiceEvent.kBreakpointResolved:
425 case ServiceEvent.kBreakpointRemoved: 425 case ServiceEvent.kBreakpointRemoved:
426 var loc = event.breakpoint.location; 426 var loc = event.breakpoint.location;
427 if (loc.script == script) { 427 if (loc.script == script) {
428 int line; 428 int line;
429 if (loc.tokenPos != null) { 429 if (loc.tokenPos != null) {
430 line = script.tokenToLine(loc.tokenPos); 430 line = script.tokenToLine(loc.tokenPos);
431 } else { 431 } else {
432 line = script.tokenToLine(loc.line); 432 line = loc.line;
433 } 433 }
434 if ((line >= _startLine) && (line <= _endLine)) { 434 if ((line >= _startLine) && (line <= _endLine)) {
435 _updateTask.queue(); 435 _updateTask.queue();
436 } 436 }
437 } 437 }
438 break; 438 break;
439 default: 439 default:
440 // Ignore. 440 // Ignore.
441 break; 441 break;
442 } 442 }
(...skipping 596 matching lines...) Expand 10 before | Expand all | Expand 10 after
1039 @CustomTag('source-inset') 1039 @CustomTag('source-inset')
1040 class SourceInsetElement extends PolymerElement { 1040 class SourceInsetElement extends PolymerElement {
1041 SourceInsetElement.created() : super.created(); 1041 SourceInsetElement.created() : super.created();
1042 1042
1043 @published SourceLocation location; 1043 @published SourceLocation location;
1044 @published String height = null; 1044 @published String height = null;
1045 @published int currentPos; 1045 @published int currentPos;
1046 @published bool inDebuggerContext = false; 1046 @published bool inDebuggerContext = false;
1047 @published ObservableList variables; 1047 @published ObservableList variables;
1048 } 1048 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698