Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1524103002: Forward the fixed flutter observatory port in `android_shell.py`. (Closed)

Created:
5 years ago by ppi
Modified:
5 years ago
Reviewers:
tonyg, qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M mojo/devtools/common/devtoolslib/android_shell.py View 1 3 chunks +9 lines, -0 lines 0 comments Download
M mojo/devtools/common/remote_adb_setup View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
ppi
Hi Ben, ptal.
5 years ago (2015-12-15 09:51:56 UTC) #3
tonyg
lgtm
5 years ago (2015-12-15 16:50:47 UTC) #5
ppi
5 years ago (2015-12-15 16:52:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d2b6d2ebe9b9c21532411300e05c0fee22aaa618 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698